Skip to content

[PWGEM/Dilepton] add phi protection in EMTrack.h #13867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsekihat merged 2 commits into from
Nov 19, 2025
Merged

[PWGEM/Dilepton] add phi protection in EMTrack.h #13867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3d582
PWGEM/Dilepton: add phi protection in EMTrack.h
dsekihat Nov 17, 2025
8cae9fd
add std::
dsekihat Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions PWGEM/Dilepton/Utils/EMTrack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,11 @@
void setPositiveLegPxPyPzM(float px, float py, float pz, float m)
{
float pt = std::sqrt(px * px + py * py);
float eta = std::atanh(pz / sqrt(std::pow(px, 2) + std::pow(py, 2) + std::pow(pz, 2)));
float eta = std::atanh(pz / std::sqrt(std::pow(px, 2) + std::pow(py, 2) + std::pow(pz, 2)));

Check failure on line 187 in PWGEM/Dilepton/Utils/EMTrack.h

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
float phi = std::atan2(py, px);
if (phi < 0.f) {
phi += 2.f * M_PI;

Check failure on line 190 in PWGEM/Dilepton/Utils/EMTrack.h

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.

Check failure on line 190 in PWGEM/Dilepton/Utils/EMTrack.h

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
}

fVPos.SetPt(pt);
fVPos.SetEta(eta);
Expand All @@ -195,8 +198,11 @@
void setNegativeLegPxPyPzM(float px, float py, float pz, float m)
{
float pt = std::sqrt(px * px + py * py);
float eta = std::atanh(pz / std::sqrt(pow(px, 2) + std::pow(py, 2) + std::pow(pz, 2)));
float eta = std::atanh(pz / std::sqrt(std::pow(px, 2) + std::pow(py, 2) + std::pow(pz, 2)));

Check failure on line 201 in PWGEM/Dilepton/Utils/EMTrack.h

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
float phi = std::atan2(py, px);
if (phi < 0.f) {
phi += 2.f * M_PI;

Check failure on line 204 in PWGEM/Dilepton/Utils/EMTrack.h

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.

Check failure on line 204 in PWGEM/Dilepton/Utils/EMTrack.h

View workflow job for this annotation

GitHub Actions / O2 linter

[two-pi-add-subtract] 

Use RecoDecay::constrainAngle to restrict angle to a given range.
}

fVNeg.SetPt(pt);
fVNeg.SetEta(eta);
Expand Down
Loading