Skip to content

[PWGUD] Switch to store SG and DG separately #13850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amatyja merged 3 commits into from
Nov 16, 2025
Merged

[PWGUD] Switch to store SG and DG separately #13850

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93d7cec
Switch to store SG and DG separately
mbroz84 Nov 16, 2025
6c0eb44
Please consider the following formatting changes
alibuild Nov 16, 2025
47c5d2b
Merge pull request #1 from alibuild/alibot-cleanup-13850
mbroz84 Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion PWGUD/TableProducer/SGCandProducer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -74,16 +74,18 @@

// get an SGCutparHolder
SGCutParHolder sameCuts = SGCutParHolder(); // SGCutparHolder
Configurable<SGCutParHolder> SGCuts{"SGCuts", {}, "SG event cuts"};

Check failure on line 77 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<bool> verboseInfo{"verboseInfo", false, "Print general info to terminal; default it false."};
Configurable<bool> saveAllTracks{"saveAllTracks", true, "save only PV contributors or all tracks associated to a collision"};
Configurable<bool> savenonPVCITSOnlyTracks{"savenonPVCITSOnlyTracks", false, "save non PV contributors with ITS only information"};
Configurable<bool> rejectAtTFBoundary{"rejectAtTFBoundary", true, "reject collisions at a TF boundary"};
Configurable<bool> noITSROFrameBorder{"noITSROFrameBorder", true, "reject ITS RO Frame Border"};
Configurable<bool> noSameBunchPileUp{"noSameBunchPileUp", true, "reject SameBunchPileUp"};
Configurable<bool> IsGoodVertex{"IsGoodVertex", false, "Select FT0 PV vertex matching"};

Check failure on line 84 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<bool> ITSTPCVertex{"ITSTPCVertex", true, "reject ITS-only vertex"}; // if one wants to look at Single Gap pp events

Check failure on line 85 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<std::vector<int>> generatorIds{"generatorIds", std::vector<int>{-1}, "MC generatorIds to process"};
Configurable<bool> storeSG{"storeSG", true, "Store SG events in the output"};
Configurable<bool> storeDG{"storeDG", true, "Store DG events in the output"};

Configurable<bool> isGoodRCTCollision{"isGoodRCTCollision", true, "Check RCT flags for FT0,ITS,TPC and tracking"};
Configurable<bool> isGoodRCTZdc{"isGoodRCTZdc", false, "Check RCT flags for ZDC if present in run"};
Expand Down Expand Up @@ -219,10 +221,10 @@
float csTCE = 10.36e6;
const float csZEM = 415.2e6; // see AN: https://alice-notes.web.cern.ch/node/1515
const float csZNC = 214.5e6; // see AN: https://alice-notes.web.cern.ch/node/1515
if (runNumber > 543437 && runNumber < 543514) {

Check failure on line 224 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
csTCE = 8.3e6;
}
if (runNumber >= 543514) {

Check failure on line 227 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
csTCE = 4.10e6; // see AN: https://alice-notes.web.cern.ch/node/1515
}

Expand Down Expand Up @@ -348,14 +350,14 @@
auto isSGEvent = sgSelector.IsSelected(sameCuts, collision, bcRange, bc);
// auto isSGEvent = sgSelector.IsSelected(sameCuts, collision, bcRange, tracks);
int issgevent = isSGEvent.value;
if (isSGEvent.bc && issgevent < 2) {

Check failure on line 353 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
newbc = *(isSGEvent.bc);
} else {
if (verboseInfo)
LOGF(info, "No Newbc %i", bc.globalBC());
}
getHist(TH1, histdir + "/Stat")->Fill(issgevent + 10, 1.);
if (issgevent <= 2) {
if ((storeDG && issgevent == o2::aod::sgselector::DoubleGap) || (storeSG && (issgevent == o2::aod::sgselector::SingleGapA || issgevent == o2::aod::sgselector::SingleGapC))) {
if (verboseInfo)
LOGF(info, "Current BC: %i, %i, %i", bc.globalBC(), newbc.globalBC(), issgevent);
if (sameCuts.minRgtrwTOF()) {
Expand Down Expand Up @@ -401,7 +403,7 @@
if (track.isPVContributor()) {
updateUDTrackTables(outputCollisions.lastIndex(), track, bc.globalBC());
} else if (saveAllTracks) {
if (track.itsClusterSizes() && track.itsChi2NCl() > 0 && ((track.tpcNClsFindable() == 0 && savenonPVCITSOnlyTracks) || track.tpcNClsFindable() > 50))

Check failure on line 406 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
updateUDTrackTables(outputCollisions.lastIndex(), track, bc.globalBC());
// if (track.isPVContributor()) updateUDTrackTables(outputCollisions.lastIndex(), track, bc.globalBC());
}
Expand Down Expand Up @@ -898,7 +900,7 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
WorkflowSpec workflow{
adaptAnalysisTask<SGCandProducer>(cfgc, TaskName{"sgcandproducer"}),

Check failure on line 903 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Device names sgcandproducer and s-g-cand-producer generated from the specified task name sgcandproducer and from the struct name SGCandProducer, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to Sgcandproducer and removing TaskName.
adaptAnalysisTask<McSGCandProducer>(cfgc, TaskName{"mcsgcandproducer"})};

Check failure on line 904 in PWGUD/TableProducer/SGCandProducer.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Device names mcsgcandproducer and mc-s-g-cand-producer generated from the specified task name mcsgcandproducer and from the struct name McSGCandProducer, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to Mcsgcandproducer and removing TaskName.
return workflow;
}
Loading