Skip to content

[PWGCF] Update femto framework #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ariedel-cern merged 2 commits into from
Nov 17, 2025
Merged

[PWGCF] Update femto framework #13848

ariedel-cern merged 2 commits into from
Nov 17, 2025

Conversation

@ariedel-cern
Copy link
Collaborator

@ariedel-cern ariedel-cern commented Nov 15, 2025

This PR contains the following changes:

  • Underlying logic/objects for computation of the bitmasks for the different particles has been improved
  • the selction object now generate histograms, couting how many particles survive specific cuts and stores the configuration about each cut in the bin lable
  • a cutculator macro has been added which can compute bitmask with user input from histograms stored by the selection objects
  • enforce existence of TOF information above a PID specific threshold more strictly to not store uneccesary particles

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

@ariedel-cern ariedel-cern marked this pull request as ready for review November 15, 2025 22:18
@ariedel-cern ariedel-cern enabled auto-merge (squash) November 15, 2025 22:19
alibuild
alibuild approved these changes Nov 15, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern
Copy link
Collaborator Author

ariedel-cern commented Nov 15, 2025

Megalinter fails because of import-error in python script (it apprently cannot import ROOT). Ignoring for now

@ariedel-cern ariedel-cern merged commit 86b3abe into AliceO2Group:master Nov 17, 2025
12 of 14 checks passed
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@ariedel-cern
[PWGCF] Update femto framework (AliceO2Group#13848)
1915424 
Megalinter error due to import error ```import ROOT``` in cutculator.py. Still merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner

@prchakra prchakra Awaiting requested review from prchakra prchakra is a code owner

@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

@glromane glromane Awaiting requested review from glromane glromane is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ariedel-cern @alibuild