-
Notifications
You must be signed in to change notification settings - Fork 613
[ALICE3] Implement task and tree creator for 3-prong candidates #13845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 52 errors, |
Please consider the following formatting changes to AliceO2Group#13845
Please consider the following formatting changes to AliceO2Group#13845
[ALICE3] Please consider the following formatting changes to AliceO2Group#13845
|
Hi all, I moved the implementation under the ALICE3 folder, please let me know if I overlooked anything! |
Hi @Marcellocosti , thanks for the update, but now it seems that you are duplicating a lot of Run3 HF stuff. I thought you would just put in ALICE3 the stuff that is different from the Run3 stuff. Why do you need a new full candidate table a new selector array and a new ML response? |
|
Hi Vit, thanks for the comment, here my ideas
Please let me know if you have any suggestion on these points |
Thanks for the clarification. Indeed, after a closer look I can see that it is not a copy-paste and it has ALICE3-specific features. That makes sense to me. |
Please consider the following formatting changes to AliceO2Group#13845
|
Hi @vkucera, I have implemented your comments! |
Thanks a lot, @Marcellocosti . Sorry, the comment about the prong index columns was a mistake. |
Head branch was pushed to by a user without write access
| [](float dca, float err) -> float { return dca / err; }); | ||
|
|
||
| /// prong PID nsigma | ||
| DECLARE_SOA_COLUMN(NSigTrkPi0, nSigTrkPi0, float); //! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you do not want an array, for nSigTrkPi0 / nSigTrkPi1 /nSigTrkPi2 ?
…eO2Group#13845) Co-authored-by: Marcello Di Costanzo <mdicosta@aliceml.cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
…eO2Group#13845) Co-authored-by: Marcello Di Costanzo <mdicosta@aliceml.cern.ch> Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Nicolò Jacazio <njacazio@users.noreply.github.com>
In this PR, the selector, task, and tree creator for simulation performance of HF 3-prong candidates is implemented. Moreover, an header to apply bdt selection is also added. The current code covers only the Lc baryon, but the aim is to cover all 3-prong species with proper templetization.