-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGHF] Added PID histograms for V0 daughter and fixed bug for selection of V0 mass window #13835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 0 errors, |
[PWGHF] Please consider the following formatting changes to AliceO2Group#13835
zhangbiao-phy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
|
Hi @singhra1994, sorry to jump in, but I wanted to warn you that using primary particle TOF (the standard TOF) for strange decay daughters may incur in a significant signal loss (up to 30-50% in proton-proton collisions). Further, this signal loss is not well reproduced by MC, which could lead to problems in case MC corrections are needed. The key problem is that primary TOF assumes the track-to-collision association stored in AO2Ds to be correct, while secondary decay daughters are often assigned to a collision that isn't the same as the V0 or Cascade they make up. To avoid this kind of issue, one should either not apply TOF at all or take these effects into account using the strangeness TOF: see this talk in the strangeness PAG, with the strangeness TOF also being mentioned in the tutorial here. A central core service wagon that provides strangeness TOF PID is also provided in hyperloop. Hope this helps! |
Thanks a lot @ddobrigk for mentioning this, indeed we were having this issue. I wrote this code to calculate data driven efficiency of proton for PID cuts using V0_lambda. I will certainly look to the material you have provided and will come back to you in case of doubt. |
Just in case: From what we've seen in the strangeness TOF PID testing, in primary TOF QA plots, you might see two effects:
In summary: the actual histogram of Nsigma might look like a gaussian, but the problem is in wildly large Nsigma values (still well-defined) and those will end up in under/overflow... |
Thanks again @ddobrigk, We (me and @arossi81 ) were exactly discussing this issue, it is useful for us |
|
@zhangbiao-phy I disabled the auto-merge just to leave room for potential modifications resulting from the discussion. If the points have been resolved, feel free to proceed with the merging. |
@vkucera @zhangbiao-phy, current version of strangeness TOF pid is not useful for our purpose. There is no harm to merge this PR, later if need we can add strangeness PID |
make sense! Thanks! Looks good to me! |
…ion of V0 mass window (AliceO2Group#13835) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…ion of V0 mass window (AliceO2Group#13835) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
No description provided.