Skip to content

Conversation

@ayankrmanna
Copy link
Contributor

Centrality dependence has been added to enable centrality-dependent D0–hadron azimuthal correlation analysis.
Additionally, the ML filtering condition was updated by changing the || to && between the D0 and D0bar selection blocks.
This makes the selection less restrictive: a candidate is now rejected only when both D0 and D0bar fail their prompt/background ML thresholds

@github-actions
Copy link

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add centrality dependence to D⁰–hadron correlation analysis [PWGHF] Add centrality dependence to D⁰–hadron correlation analysis Nov 13, 2025
@vkucera
Copy link
Collaborator

vkucera commented Nov 13, 2025

@ayankrmanna How is this different from #13719 ?

@vkucera vkucera marked this pull request as draft November 13, 2025 11:51
@ayankrmanna
Copy link
Contributor Author

Hi @vkucera The previous PR had many unintended changes related to linting, formatting and multiple commits (it was my first attempt, and I was not yet familiar with the CI/linter requirements).
This made the diff unnecessarily large and difficult to review. In this new PR, I cleaned everything and included only the intended functional changes.

  • Added centrality dependence to the D⁰–hadron correlation task.
  • Updated the ML filtering logic (|| → &&) with a clear justification.
    So logically the code remains the same, but this PR contains a clean and minimal diff without formatting noise.

@vkucera
Copy link
Collaborator

vkucera commented Nov 13, 2025

Hi @vkucera The previous PR had many unintended changes related to linting, formatting and multiple commits (it was my first attempt, and I was not yet familiar with the CI/linter requirements). This made the diff unnecessarily large and difficult to review. In this new PR, I cleaned everything and included only the intended functional changes.

* Added centrality dependence to the D⁰–hadron correlation task.

* Updated the ML filtering logic (|| → &&) with a clear justification.
  So logically the code remains the same, but this PR contains a clean and minimal diff without formatting noise.

I don't know which noise you're talking about. The only difference between the two PRs are the removed includes. If you want to make changes to your PR, update the PR and don't duplicate it.

@vkucera vkucera closed this Nov 13, 2025
@ayankrmanna
Copy link
Contributor Author

Okay, @vkucera — I will continue updating the original PR on the same branch.

@ayankrmanna ayankrmanna deleted the add-centrality-in-d0-hadrons-correlation branch November 14, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants