Skip to content

[Common] Add protection for malformed ambiguous track table entries in AO2Ds #13794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddobrigk merged 3 commits into from
Nov 13, 2025
Merged

[Common] Add protection for malformed ambiguous track table entries in AO2Ds #13794

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4473d84
Add protection for malformed ambiguous track table entries in AO2Ds
fgrosa Nov 12, 2025
1241dc0
Make linter happy
fgrosa Nov 12, 2025
a53999a
Revert wrong linter suggestion
fgrosa Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Common/Core/CollisionAssociation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ class CollisionAssociation
switch (mTrackSelection) {
case o2::aod::track_association::TrackSelection::CentralBarrelRun2: {
unsigned char itsClusterMap = track.itsClusterMap();
if (!(track.tpcNClsFound() >= 50 && track.flags() & o2::aod::track::ITSrefit && track.flags() & o2::aod::track::TPCrefit && (TESTBIT(itsClusterMap, 0) || TESTBIT(itsClusterMap, 1)))) {
int minTpcNClsFound{50};
if (!(track.tpcNClsFound() >= minTpcNClsFound && track.flags() & o2::aod::track::ITSrefit && track.flags() & o2::aod::track::TPCrefit && (TESTBIT(itsClusterMap, 0) || TESTBIT(itsClusterMap, 1)))) {
hasGoodQuality = false;
}
break;
Expand Down Expand Up @@ -127,7 +128,7 @@ class CollisionAssociation
TTracksUnfiltered const& tracksUnfiltered,
TTracks const& tracks,
TAmbiTracks const& ambiguousTracks,
o2::aod::BCs const&,
o2::aod::BCs const& bcs,
Assoc& association,
RevIndices& reverseIndices)
{
Expand All @@ -151,6 +152,11 @@ class CollisionAssociation
for (const auto& ambTrack : ambiguousTracks) {
if constexpr (isCentralBarrel) { // FIXME: to be removed as soon as it is possible to use getId<Table>() for joined tables
if (ambTrack.trackId() == track.globalIndex()) {
// special check to avoid crashes (in particular on some MC datasets)
// related to shifts in ambiguous tracks association to bc slices (off by 1) - see https://mattermost.web.cern.ch/alice/pl/g9yaaf3tn3g4pgn7c1yex9copy
if (ambTrack.bcIds()[0] >= bcs.size() || ambTrack.bcIds()[1] >= bcs.size()) {
break;
}
if (!ambTrack.has_bc() || ambTrack.bc().size() == 0) {
break;
}
Expand Down Expand Up @@ -194,7 +200,7 @@ class CollisionAssociation
uint64_t collBC = collision.bc().globalBC();

// This is done per block to allow optimization below. Within each block the globalBC increase continously
for (auto& iterationWindow : trackIterationWindows) {
for (auto& iterationWindow : trackIterationWindows) { // o2-linter: disable=const-ref-in-for-loop (iterationWindow is modified)
bool iteratorMoved = false;
const bool isAssignedTrackWindow = (iterationWindow.first != iterationWindow.second) ? iterationWindow.first.has_collision() : false;
for (auto trackInWindow = iterationWindow.first; trackInWindow != iterationWindow.second; ++trackInWindow) {
Expand Down
Loading