[PWGCF] Fix indexing between track and collision tables + dimension of THn histogram #13793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmodak
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
Comment on lines
106
to
112
| using CollTable = aod::CollLRTables; | ||
| using TrkTable = aod::TrkLRTables; | ||
| using MftTrkTable = aod::MftTrkLRTables; | ||
| using Ft0aTrkTable = aod::Ft0aLRTables; | ||
| using Ft0cTrkTable = aod::Ft0cLRTables; | ||
| using MftbestTrkTable = aod::MftBestTrkLRTables; | ||
| using V0TrkTable = aod::V0TrkLRTables; |
Collaborator
There was a problem hiding this comment.
I would keep the plurals because they are not iterators
But not in the same way as in LR
Is Colls what should be plural and not Tables
The same for the others
Collaborator
Author
There was a problem hiding this comment.
Thanks!
It is done
Comment on lines
300
to
343
| void processTpcft0aME(CollTable const& col, TrkTable const& tracks, Ft0aTrkTable const& ft0as) | ||
| { | ||
| processMixed(col, tracks, ft0as); | ||
| } | ||
|
|
||
| void processTpcft0cME(aod::CollLRTables const& col, aod::TrkLRTables const& tracks, aod::Ft0cLRTables const& ft0cs) | ||
| void processTpcft0cME(CollTable const& col, TrkTable const& tracks, Ft0cTrkTable const& ft0cs) | ||
| { | ||
| processMixed(col, tracks, ft0cs); | ||
| } | ||
|
|
||
| void processTpcmftME(aod::CollLRTables const& col, aod::TrkLRTables const& tracks, aod::MftTrkLRTables const& mfts) | ||
| void processTpcmftME(CollTable const& col, TrkTable const& tracks, MftTrkTable const& mfts) | ||
| { | ||
| processMixed(col, tracks, mfts); | ||
| } | ||
|
|
||
| void processMftft0aME(aod::CollLRTables const& col, aod::MftTrkLRTables const& mfts, aod::Ft0aLRTables const& ft0as) | ||
| void processMftft0aME(CollTable const& col, MftTrkTable const& mfts, Ft0aTrkTable const& ft0as) | ||
| { | ||
| processMixed(col, mfts, ft0as); | ||
| } | ||
|
|
||
| void processV0ft0aME(aod::CollLRTables const& col, aod::V0TrkLRTables const& tracks, aod::Ft0aLRTables const& ft0as) | ||
| void processV0ft0aME(CollTable const& col, V0TrkTable const& tracks, Ft0aTrkTable const& ft0as) | ||
| { | ||
| processMixed(col, tracks, ft0as); | ||
| } | ||
|
|
||
| void processV0mftME(aod::CollLRTables const& col, aod::V0TrkLRTables const& tracks, aod::MftTrkLRTables const& mfts) | ||
| void processV0mftME(CollTable const& col, V0TrkTable const& tracks, MftTrkTable const& mfts) | ||
| { | ||
| processMixed(col, tracks, mfts); | ||
| } | ||
|
|
||
| void processTpcmftbestME(aod::CollLRTables const& col, aod::TrkLRTables const& tracks, aod::MftBestTrkLRTables const& mfts) | ||
| void processTpcmftbestME(CollTable const& col, TrkTable const& tracks, MftbestTrkTable const& mfts) | ||
| { | ||
| processMixed(col, tracks, mfts); | ||
| } | ||
|
|
||
| void processMftbestft0aME(aod::CollLRTables const& col, aod::MftBestTrkLRTables const& mfts, aod::Ft0aLRTables const& ft0as) | ||
| void processMftbestft0aME(CollTable const& col, MftbestTrkTable const& mfts, Ft0aTrkTable const& ft0as) | ||
| { | ||
| processMixed(col, mfts, ft0as); | ||
| } | ||
|
|
||
| void processV0mftbestME(aod::CollLRTables const& col, aod::V0TrkLRTables const& tracks, aod::MftBestTrkLRTables const& mfts) | ||
| void processV0mftbestME(CollTable const& col, V0TrkTable const& tracks, MftbestTrkTable const& mfts) | ||
| { | ||
| processMixed(col, tracks, mfts); | ||
| } |
Collaborator
There was a problem hiding this comment.
Also in here col should be cols
Collaborator
Author
There was a problem hiding this comment.
Thanks! It is done.
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Why the PR title if what is being fixed are the dimensions of the THn histograms?
abmodak
changed the title
Collaborator
Author
|
Hi @victor-gonzalez, your comments are implemented. Can you please approve the PR? Thanks! |
prchakra
approved these changes
Nov 12, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.