[PWGCF] Adding a task for two particle correlation in pp #13775

JosueMtzGar · 2025-11-11T06:42:10Z

I am adding a new task for the calculus of two particle correlation in pp in order to calculate the baseline in a template fit

github-actions · 2025-11-11T06:42:25Z

O2 linter results: ❌ 1 errors, ⚠️ 2 warnings, 🔕 0 disabled

JosueMtzGar · 2025-11-11T07:32:37Z

Hi reviewers

The errors remaining in the O2 linter correspond to workflow names from other task, I did not want to change them to not affect the work of other analysis. Could you approve this PR ignoring them? or Have I change the names to?

alibuild · 2025-11-11T08:34:49Z

Error while checking build/O2Physics/o2 for dacf271 at 2025-11-12 02:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13775-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationPp.cxx:273:49: error: unused parameter 'collision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

victor-gonzalez · 2025-11-11T16:08:15Z

@JosueMtzGar Please, fix the compiler error

victor-gonzalez · 2025-11-12T10:35:37Z

PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationPp.cxx

+          if (minMultiplicity <= multiplicity) {
+            histos.fill(HIST("sameEvent2D"), deltaEta, deltaPhi);
+          }
+          if (minMultiplicity <= multiplicity && multiplicity <= range1Max) {
+            histos.fill(HIST("sameEvent_2_10"), deltaEta, deltaPhi);
+          }
+          if (range2Min <= multiplicity && multiplicity <= range2Max) {
+            histos.fill(HIST("sameEvent_11_20"), deltaEta, deltaPhi);
+          }
+          if (range3Min <= multiplicity && multiplicity <= range3Max) {
+            histos.fill(HIST("sameEvent_21_30"), deltaEta, deltaPhi);
+          }
+          if (range4Min <= multiplicity && multiplicity <= range4Max) {
+            histos.fill(HIST("sameEvent_31_40"), deltaEta, deltaPhi);
+          }
+          if (range5Min <= multiplicity && multiplicity <= range5Max) {
+            histos.fill(HIST("sameEvent_41_50"), deltaEta, deltaPhi);
+          }


This is performed in a double inner loop of tracks, all the conditionals will be explored although only one, as much, will be true
This increase the execution CPU without any purpose
Is there a better way of implement it?

Now, I am using a else if conditional and a final continue to reduce the steps in the exploration

victor-gonzalez · 2025-11-12T10:36:12Z

PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationPp.cxx

+          if (minMultiplicity <= multiplicity) {
+            histos.fill(HIST("mixedEvent2D"), deltaEta, deltaPhi);
+          }
+          if (minMultiplicity <= multiplicity && multiplicity <= range1Max) {
+            histos.fill(HIST("mixedEvent_2_10"), deltaEta, deltaPhi);
+          }
+          if (range2Min <= multiplicity && multiplicity <= range2Max) {
+            histos.fill(HIST("mixedEvent_11_20"), deltaEta, deltaPhi);
+          }
+          if (range3Min <= multiplicity && multiplicity <= range3Max) {
+            histos.fill(HIST("mixedEvent_21_30"), deltaEta, deltaPhi);
+          }
+          if (range4Min <= multiplicity && multiplicity <= range4Max) {
+            histos.fill(HIST("mixedEvent_31_40"), deltaEta, deltaPhi);
+          }
+          if (range5Min <= multiplicity && multiplicity <= range5Max) {
+            histos.fill(HIST("mixedEvent_41_50"), deltaEta, deltaPhi);
+          }


victor-gonzalez · 2025-11-12T10:39:34Z

PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationPp.cxx

+  struct SameEventTag {
+  };
+  struct MixedEventTag {
+  };


Why structs and not a single enum with two constant named values?

victor-gonzalez · 2025-11-12T10:41:44Z

PWGCF/TwoParticleCorrelations/Tasks/twoParticleCorrelationPp.cxx

+    return true;
+  }
+
+  template <typename TTarget, typename TTracks, typename TTag>


Why templating on TTag? Will not a single function argument work?

This was one way I found to implement a difference in the histogram filling between same and mixed events. Now I’ve figured out how to do this in the other tasks using an enum. I’m not sure which approach is more efficient, but I guess the enum is simpler.

…e for event count by multiplicity range

victor-gonzalez

Please, fix linter warnings in the new code for the next iteration

victor-gonzalez · 2025-11-14T17:13:37Z

BTW, you haven't replied to my questions about why the structs and why template on TTag

…p#13775)

JosueMtzGar added 4 commits November 11, 2025 00:36

taking off the NUA correction and adding new histos for correlation

6a2be6d

taking off the NUA correction and adding new histos for correlation

b07bc6c

adding a basis task for two particle correlation for pp

60963c4

adding selection criteria

76ffe43

github-actions bot added the pwgcf label Nov 11, 2025

github-actions bot changed the title ~~PWGCF: Adding a task for two particle correlation in pp~~ [PWGCF] Adding a task for two particle correlation in pp Nov 11, 2025

resolving o2 linter issues

45797a8

alibuild mentioned this pull request Nov 11, 2025

Please consider the following formatting changes to #13775 JosueMtzGar/O2Physics#14

Closed

JosueMtzGar added 3 commits November 11, 2025 01:11

resolving o2 linter issues

e62c3c7

resolving o2 linter issues

af22b7a

resolving o2 linter issues

dacf271

JosueMtzGar marked this pull request as ready for review November 11, 2025 07:28

JosueMtzGar requested review from alibuild, ariedel-cern, glromane, lauraser, lgraczykCern, otonvd, prchakra, shouqiye, victor-gonzalez and zchochul as code owners November 11, 2025 07:28

fixing compiler issues

c4bfe7c

victor-gonzalez reviewed Nov 12, 2025

View reviewed changes

fixing compiler issues, attending comments from review and adding cod…

fc14fe0

…e for event count by multiplicity range

alibuild mentioned this pull request Nov 13, 2025

Please consider the following formatting changes to #13775 JosueMtzGar/O2Physics#15

Closed

fixing formating issue

91f9317

victor-gonzalez approved these changes Nov 14, 2025

View reviewed changes

victor-gonzalez enabled auto-merge (squash) November 14, 2025 17:11

victor-gonzalez merged commit a98d1e4 into AliceO2Group:master Nov 15, 2025
13 of 15 checks passed

lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025

[PWGCF] Adding a task for two particle correlation in pp (AliceO2Grou…

602bee8

…p#13775)

[PWGCF] Adding a task for two particle correlation in pp #13775

[PWGCF] Adding a task for two particle correlation in pp #13775

Uh oh!

Conversation

JosueMtzGar commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JosueMtzGar commented Nov 11, 2025

Uh oh!

alibuild commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

victor-gonzalez commented Nov 11, 2025

Uh oh!

victor-gonzalez Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JosueMtzGar Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

JosueMtzGar Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez left a comment

Choose a reason for hiding this comment

Uh oh!

victor-gonzalez commented Nov 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 11, 2025 •

edited

Loading

alibuild commented Nov 11, 2025 •

edited

Loading

victor-gonzalez Nov 12, 2025 •

edited

Loading

JosueMtzGar Nov 13, 2025 •

edited

Loading