Skip to content

Conversation

@rashigupt
Copy link
Contributor

@rashigupt rashigupt commented Nov 11, 2025

Add 3d histogram TPCTOFvsp before electron selection in correlationHFEHadron.cxx

@github-actions github-actions bot added the pwghf PWG-HF label Nov 11, 2025
@github-actions github-actions bot changed the title Add 3d histogram TPCTOFvsp before electron selection [PWGHF] Add 3d histogram TPCTOFvsp before electron selection Nov 11, 2025
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@rashigupt rashigupt changed the title [PWGHF] Add 3d histogram TPCTOFvsp before electron selection Add 3d histogram TPCTOFvsp before electron selection in correlationHFEHadron.cxx Nov 11, 2025
@github-actions github-actions bot changed the title Add 3d histogram TPCTOFvsp before electron selection in correlationHFEHadron.cxx [PWGHF] Add 3d histogram TPCTOFvsp before electron selection in correlationHFEHadron.cxx Nov 11, 2025
@vkucera
Copy link
Collaborator

vkucera commented Nov 11, 2025

  • Why do you need 59 commits to add one histogram?
  • The other two histograms seem useless.
  • The other two histograms are not filled anywhere.
  • Why are you switching the default activation of process functions?

@vkucera vkucera marked this pull request as draft November 11, 2025 04:23
@rashigupt rashigupt closed this Nov 11, 2025
@rashigupt rashigupt reopened this Nov 11, 2025
@rashigupt
Copy link
Contributor Author

rashigupt commented Nov 11, 2025

Hi @vkucera , I have fixed the issue with the 59 commits. The other two histograms are now filled after the electron selection.

Copy link
Collaborator

@jpxrk jpxrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TH2? not TH3?

@rashigupt
Copy link
Contributor Author

Is this TH2? not TH3?

sorry, this is TH3

jpxrk
jpxrk previously approved these changes Nov 11, 2025
registry.add("hULSEHCorrel", "Sparse for Delta phi and Delta eta UnLike sign Electron pair with Hadron;p_{T}^{e} (GeV#it{/c});p_{T}^{h} (GeV#it{/c});#Delta#varphi;#Delta#eta;", {HistType::kTHnSparseF, {{axisPt}, {axisPt}, {axisDeltaPhi}, {axisDeltaEta}}});
registry.add("hTofnSigmaVsP", " Tof nSigma info vs P; n#sigma;#it{p} (GeV#it{/c});passEMcal;", {HistType::kTH2F, {{axisNSigma}, {axisPt}}});
registry.add("hTpcnSigmaVsP", " TPC nSigma info vs P; n#sigma;#it{p} (GeV#it{/c});passEMcal;", {HistType::kTH2F, {{axisNSigma}, {axisPt}}});
registry.add("hTofnSigmaVsP", " Tof nSigma info vs P; n#sigma;#it{p} (GeV#it{/c});", {HistType::kTH2F, {{axisNSigma}, {axisPt}}});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What does "TOF nSigma info" mean?
  • momentum is p, not P.

Copy link
Contributor Author

@rashigupt rashigupt Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is nsigma with the TOF detector for electron

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it is just "TOF nSigma", not "TOF nSigma info".

@vkucera
Copy link
Collaborator

vkucera commented Nov 11, 2025

Hi @vkucera , I have fixed the issue with the 59 commits. The other two histograms are now filled after the electron selection.

It's not mentioned anywhere in their definitions.

@rashigupt rashigupt marked this pull request as ready for review November 11, 2025 10:22
@rashigupt
Copy link
Contributor Author

Dear expert, please approve and merge the code

@jpxrk jpxrk enabled auto-merge (squash) November 12, 2025 11:01
@jpxrk jpxrk merged commit bbbc17f into AliceO2Group:master Nov 12, 2025
12 of 13 checks passed
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants