Skip to content

[PWGJE] trackEfficiency: FT0M or C for centrality, other fixes/cleaning #13729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nzardosh merged 3 commits into from
Nov 21, 2025
Merged

[PWGJE] trackEfficiency: FT0M or C for centrality, other fixes/cleaning #13729

nzardosh merged 3 commits into from
Nov 21, 2025

Conversation

@aimeric-landou
Copy link
Contributor

@aimeric-landou aimeric-landou commented Nov 7, 2025

  • add filter (posZ) to collision iterators
  • fix processTrackSelectionHistograms subscription
  • clean some comments in code
  • simPtRef now global
  • fix default cent binning
  • single line for centrality declaration
  • checkCentrality renamed cutCentrality

@aimeric-landou
[PWGJE] trackEfficiency: allows one to choose FT0M or C for centralit…
73a071a 
…y, add filter (posZ) to collision iterators, fix processTrackSelectionHistograms subscription, clean some comments in code, simPtRef now global, fix default cent binning, single line for centrality declaration, checkCentrality renamed cutCentrality
@github-actions github-actions bot added the pwgje label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild
Copy link
Collaborator

alibuild commented Nov 8, 2025

Error while checking build/O2Physics/o2 for 73a071a at 2025-11-08 06:50:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:437:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:605:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:737:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:837:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:889:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:900:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:926:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:963:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:1001:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:1058:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:152:53: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:152:53: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:169:51: error: operation on 'centrality' may be undefined [-Werror=sequence-point]
ninja: build stopped: subcommand failed.

Full log here.

nzardosh
nzardosh reviewed Nov 10, 2025
View reviewed changes
PWGJE/Tasks/trackEfficiency.cxx Outdated
registry.fill(HIST("hMcCollCutsCounts"), 4.5, mcCollision.weight()); // at least one of the reconstructed collisions associated with this mcCollision is selected

if (!centralityCheck) {
float centrality = checkCentFT0M ? centrality = mcCollision.centFT0M() : centrality = mcCollision.centFT0C();
Copy link
Collaborator

@nzardosh nzardosh Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aimeric. It seems the centFT0C tables are not calibrated and filled by LF for mcCollisions. I am making a PR to remove them entirely from our data model. Could you remove them in this PR too please?

@aimeric-landou
temporarily change mccol.cent to coll.cent for MC colls, add cent cut…
3e01b91 
… to processTracksMc and processTrackSelectionHistograms
nzardosh
nzardosh previously approved these changes Nov 20, 2025
View reviewed changes
@nzardosh nzardosh enabled auto-merge (squash) November 20, 2025 09:14
@alibuild
Copy link
Collaborator

alibuild commented Nov 21, 2025

Error while checking build/O2Physics/o2 for 3e01b91 at 2025-11-21 11:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13729-slc9_x86-64/0/PWGJE/Tasks/trackEfficiency.cxx:167:52: error: unused parameter 'mcCollision' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

auto-merge was automatically disabled November 21, 2025 11:08

Head branch was pushed to by a user without write access

@nzardosh nzardosh self-requested a review November 21, 2025 18:25
@nzardosh nzardosh enabled auto-merge (squash) November 21, 2025 18:25
@nzardosh nzardosh merged commit 1a9840d into AliceO2Group:master Nov 21, 2025
20 of 23 checks passed
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@aimeric-landou
[PWGJE] trackEfficiency: FT0M or C for centrality, other fixes/cleani…
906b8fb 
…ng (AliceO2Group#13729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzardosh nzardosh nzardosh approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aimeric-landou @alibuild @nzardosh