Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions PWGEM/Dilepton/Utils/MCUtilities.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
template <typename T>
bool isCharmonia(T const& track)
{
if (std::abs(track.pdgCode()) < 100) {

Check failure on line 77 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}

Expand All @@ -82,7 +82,7 @@
int n = pdgStr.length();
int pdg3 = std::stoi(pdgStr.substr(n - 3, 3));

if (pdg3 == 441 || pdg3 == 443 || pdg3 == 445 || pdg3 == 447) {

Check failure on line 85 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

Check failure on line 85 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return true;
} else {
return false;
Expand All @@ -96,7 +96,7 @@
return false;
}

if (400 < std::abs(track.pdgCode()) && std::abs(track.pdgCode()) < 500) {

Check failure on line 99 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return true;
} else {
return false;
Expand All @@ -106,7 +106,7 @@
template <typename T>
bool isCharmBaryon(T const& track)
{
if (4000 < std::abs(track.pdgCode()) && std::abs(track.pdgCode()) < 5000) {

Check failure on line 109 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return true;
} else {
return false;
Expand All @@ -124,7 +124,7 @@
int n = pdgStr.length();
int pdg3 = std::stoi(pdgStr.substr(n - 3, 3));

if (pdg3 == 551 || pdg3 == 553 || pdg3 == 555 || pdg3 == 557) {

Check failure on line 127 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return true;
} else {
return false;
Expand Down Expand Up @@ -162,9 +162,9 @@
if (!mcParticle.has_mothers()) {
return false;
}
if (mcParticle.getProcess() != 4) { // weak decay
return false;
}
// if (mcParticle.getProcess() != 4) { // weak decay
// return false;
// }
auto mp = mcParticles.iteratorAt(mcParticle.mothersIds()[0]);
if (isCharmMeson(mp) || isCharmBaryon(mp)) {
return true;
Expand All @@ -180,9 +180,9 @@
if (!mcParticle.has_mothers()) {
return false;
}
if (mcParticle.getProcess() != 4) { // weak decay
return false;
}
// if (mcParticle.getProcess() != 4) { // weak decay
// return false;
// }
auto mp = mcParticles.iteratorAt(mcParticle.mothersIds()[0]);
if (isBeautyMeson(mp) || isBeautyBaryon(mp)) {
return true;
Expand Down Expand Up @@ -430,7 +430,7 @@
while (motherid1 > -1) {
if (motherid1 < mcParticles.size()) { // protect against bad mother indices. why is this needed?
auto mp = mcParticles.iteratorAt(motherid1);
if ((std::abs(mp.pdgCode()) == 511 || std::abs(mp.pdgCode()) == 531) && mp.getGenStatusCode() == 92) {

Check failure on line 433 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
return true;
}

Expand Down Expand Up @@ -477,7 +477,7 @@

int counter = 0;
for (const auto& pdg : mothers_pdg) {
if (std::abs(pdg) <= 6 || std::abs(pdg) == 21 || (std::abs(pdg) == 2212 && counter == static_cast<int>(mothers_pdg.size() - 1)) || (std::abs(pdg) > 1e+9 && counter == static_cast<int>(mothers_pdg.size() - 1))) { // quarks or gluon or proton or ion beam

Check failure on line 480 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code]

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
break;
}
counter++;
Expand Down Expand Up @@ -690,7 +690,7 @@
if (equal) { // we are searching for the quark
int quark_id = -1;
int next_mother_id = -1;
for (int i : allmothersids) {

Check failure on line 693 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
auto mother = mcParticles.iteratorAt(i);
int mpdg = mother.pdgCode();
// if (std::abs(mpdg) == pdg && mpdg * p.pdgCode() > 0) { // check for quark
Expand Down Expand Up @@ -719,7 +719,7 @@
return -1;
} else { // searching for first ancestor that is not quark anymore
int quark_id = -1;
for (int i : allmothersids) {

Check failure on line 722 in PWGEM/Dilepton/Utils/MCUtilities.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
auto mother = mcParticles.iteratorAt(i);
int mpdg = std::abs(mother.pdgCode());
if (mpdg == pdg && mother.pdgCode() == p.pdgCode()) { // found the quark
Expand Down
Loading