Skip to content

[PWGHF] replace legacy decay channels for SigmaC. #13689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfaggin merged 7 commits into from
Nov 13, 2025
Merged

[PWGHF] replace legacy decay channels for SigmaC. #13689

mfaggin merged 7 commits into from
Nov 13, 2025

Conversation

@mfaggin
Copy link
Collaborator

@mfaggin mfaggin commented Nov 5, 2025

@lauraser this should do the job

@github-actions github-actions bot added the pwghf PWG-HF label Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025 •
edited
Loading

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 2 disabled

@github-actions github-actions bot changed the title [PWGHF]: replace legacy decay channels for SigmaC. [PWGHF] replace legacy decay channels for SigmaC. Nov 5, 2025
@lauraser
Copy link
Collaborator

lauraser commented Nov 5, 2025

Thanks a lot @mfaggin !!

@vkucera vkucera marked this pull request as draft November 5, 2025 10:27
vkucera
vkucera requested changes Nov 5, 2025
View reviewed changes
@mfaggin mfaggin marked this pull request as ready for review November 10, 2025 20:12
@mfaggin
Copy link
Collaborator Author

mfaggin commented Nov 10, 2025

thanks @vkucera I re-enable it for review, since I think that your comments have been addressed. Let me know

@mfaggin
Copy link
Collaborator Author

mfaggin commented Nov 10, 2025

Trying to remove the legacy channels I see that in PWGHF/HFC/Utils/utilsCorrelations.h these are still used. Since it's not my code, and I do not want to compromise the logic, I'd leave it to @singhra1994 . I propose to leave it to him after this PR is merged.

@mfaggin
Copy link
Collaborator Author

mfaggin commented Nov 11, 2025

Hi, I changed my mind. With the modified version of the candidateCreatorSigmac the HFC code cannot work anymore, because the flagging is done in a different way. Therefore, I decided to adapt the HFC code as well. Please @singhra1994 have a look, my modifications should be harmless but please tell me if this is not the case.

From my side, everything is ready to go @vkucera

vkucera
vkucera approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mfaggin ! Looks good to me.

@mfaggin mfaggin merged commit 216f647 into AliceO2Group:master Nov 13, 2025
12 of 13 checks passed
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@mfaggin
[PWGHF] replace legacy decay channels for SigmaC. (AliceO2Group#13689)
2b20765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfaggin @lauraser @vkucera