Skip to content

[PWGLF] Clean PIDResponse in PWGLF #13672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 3 commits into from
Nov 5, 2025
Merged

[PWGLF] Clean PIDResponse in PWGLF #13672

njacazio merged 3 commits into from
Nov 5, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Nov 4, 2025

No description provided.

@github-actions github-actions bot added the pwglf label Nov 4, 2025
@github-actions github-actions bot changed the title Clean PIDResponse in PWGLF [PWGLF] Clean PIDResponse in PWGLF Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

O2 linter results: ❌ 5256 errors, ⚠️ 3896 warnings, 🔕 33 disabled

@njacazio njacazio marked this pull request as ready for review November 4, 2025 09:58
maciacco
maciacco previously approved these changes Nov 4, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Nov 4, 2025

Error while checking build/O2Physics/o2 for bad5a08 at 2025-11-04 11:47:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:100:37: error: 'aod' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:100:53: error: expected unqualified-id before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:100:53: error: expected ')' before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:100:53: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:100:55: error: 'mcParticles' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:128:39: error: 'aod' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:128:55: error: expected unqualified-id before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:128:55: error: expected ')' before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:128:55: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:128:57: error: 'mcParticles' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:159:25: error: 'aod' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:159:41: error: expected unqualified-id before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:159:41: error: expected ')' before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:159:41: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:159:43: error: 'mcParticles' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:160:25: error: 'aod' does not name a type
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:160:41: error: expected unqualified-id before '&' token
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/Utils/inelGt.h:160:41: error: expected ')' before '&' token
[0 more errors; see full log]

Full log here.

maciacco
maciacco previously approved these changes Nov 4, 2025
View reviewed changes
romainschotter
romainschotter previously approved these changes Nov 4, 2025
View reviewed changes
@njacazio njacazio dismissed stale reviews from romainschotter and maciacco via 3aa1e26 November 4, 2025 17:25
@alibuild
Copy link
Collaborator

alibuild commented Nov 5, 2025

Error while checking build/O2Physics/o2 for 7058483 at 2025-11-05 13:02:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:137:26: error: 'DcaXY' is not a member of 'o2::aod::track'
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:138:26: error: 'DcaZ' is not a member of 'o2::aod::track'
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:131:1: error: template argument 7 is invalid
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:131:1: error: template argument 8 is invalid
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:131:19: error: 'HypKfTracksMetadata' does not name a type; did you mean 'HypKfMcPartsMetadata'?
/sw/slc9_x86-64/O2/daily-20251105-0000-local1/include/Framework/ASoA.h:1781:52: error: no matching function for call to 'getColumns<o2::soa::Table<o2::aod::Hash<4083223838>, o2::aod::Hash<1988934826>, o2::aod::Hash<2286545062> >::ref>()'
/sw/slc9_x86-64/O2/daily-20251105-0000-local1/include/Framework/ASoA.h:1781:52: error: no type named 'metadata' in 'struct o2::aod::MetadataTrait<o2::aod::Hash<1988934826> >'
/sw/slc9_x86-64/O2/daily-20251105-0000-local1/include/Framework/ASoA.h:1921:15: error: type 'o2::soa::DefaultIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<4083223838>, o2::aod::Hash<1988934826>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Table<o2::aod::Hash<4083223838>, o2::aod::Hash<1988934826>, o2::aod::Hash<2286545062> > >'
/sw/slc9_x86-64/O2/daily-20251105-0000-local1/include/Framework/ASoA.h:1921:15: error: type 'o2::soa::FilteredIndexPolicy' is not a base type for type 'o2::soa::Table<o2::aod::Hash<4083223838>, o2::aod::Hash<1988934826>, o2::aod::Hash<2286545062> >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Table<o2::aod::Hash<4083223838>, o2::aod::Hash<1988934826>, o2::aod::Hash<2286545062> > >'
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/hypKfRecoTask.cxx:963:31: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<4083223838>, o2::aod::Hash<1988934826>, o2::aod::Hash<2286545062> > >) (int, const float&, const float&, const float&, float&, float&, o2::aod::track::TPCNClsFound<o2::aod::track::TPCNClsFindable, o2::aod::track::TPCNClsFindableMinusFound>::type, const float&, const unsigned int&, const float&, float, const float&, float&, float&, float&, const float&, o2::aod::track::IsPVContributor<o2::aod::track::Flags>::type)'
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:137:26: error: 'DcaXY' is not a member of 'o2::aod::track'
/sw/SOURCES/O2Physics/13672-slc9_x86-64/0/PWGLF/DataModel/LFHypernucleiKfTables.h:138:26: error: 'DcaZ' is not a member of 'o2::aod::track'
[0 more errors; see full log]

Full log here.

@njacazio njacazio merged commit 4a92058 into master Nov 5, 2025
17 of 23 checks passed
@njacazio njacazio deleted the nj-pidresponse-pwglf branch November 5, 2025 14:18
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@njacazio
[PWGLF] Clean PIDResponse in PWGLF (AliceO2Group#13672)
f9a1220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skundu692 skundu692 skundu692 approved these changes

@maciacco maciacco maciacco left review comments

@romainschotter romainschotter romainschotter left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@njacazio @alibuild @maciacco @romainschotter @skundu692