Skip to content

Please consider the following formatting changes to #13639 #13648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Nov 2, 2025
Merged

Please consider the following formatting changes to #13639 #13648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tutorials/OpenData/flowAnalysis.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
HistogramRegistry histos{"Histos", {}, OutputObjHandlingPolicy::AnalysisObject};

Filter collisionFilter = (aod::collision::flags & (uint16_t)aod::collision::CollisionFlagsRun2::Run2VertexerTracks) == (uint16_t)aod::collision::CollisionFlagsRun2::Run2VertexerTracks;
Filter trackFilter = ((requireGlobalTrackInFilter()) || (aod::track::isGlobalTrackSDD == (uint8_t)true));
Filter trackFilter = ((requireGlobalTrackInFilter()) || (aod::track::isGlobalTrackSDD == (uint8_t) true));

void fillAPt(double trackpt, double cent, double vn, double sinHarm, double cosHarm)
{
Expand Down Expand Up @@ -313,9 +313,9 @@

auto getDoubleCountingPi = [&](Double_t nSpi, Short_t minNSigma) { return (nSpi < nsigCut && minNSigma != 1); };

auto getDoubleCountingK = [&](Double_t nSk, Short_t minNSigma) { return (nSk < nsigCut && minNSigma != 2); };

Check failure on line 316 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

auto getDoubleCountingP = [&](Double_t nSp, Short_t minNSigma) { return (nSp < nsigCut && minNSigma != 3); };

Check failure on line 318 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.

if ((eventSelection == 1) && (!collision.alias_bit(kINT7) || !collision.sel7())) {
// LOGF(info, "Collision index : %d skipped not kINT7", collision.index());
Expand All @@ -326,13 +326,13 @@
if (collision.numContrib() > 1) {
float zRes = TMath::Sqrt(collision.covZZ());
bool vertexerZ = collision.flags() == aod::collision::Run2VertexerZ;
if (vertexerZ && zRes > 0.25 && collision.numContrib() < 20)

Check failure on line 329 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
zvtx = -999;
else
zvtx = collision.posZ();
}

if (zvtx < -990)

Check failure on line 335 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
histos.fill(HIST("vtx"), 0);
else
histos.fill(HIST("vtx"), 1);
Expand All @@ -344,7 +344,7 @@
auto cl1Centr = collision.centRun2CL1();
auto cl0Centr = collision.centRun2CL0();

if (v0Centr >= 80. || v0Centr < 0)

Check failure on line 347 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return;

// cannot use vertex quality comparing SPD and Trk vertices as below
Expand Down Expand Up @@ -379,7 +379,7 @@
//clusters SDD+SSD
AliVMultiplicity* mult = aod->GetMultiplicity();
Int_t nCluSDDSSD=0;
for(Int_t iLay = 2; iLay < 6; iLay++)

Check failure on line 382 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
nCluSDDSSD += mult->GetNumberOfITSClusters(iLay);
*/

Expand All @@ -399,7 +399,7 @@
// Tracks are already filtered with GlobalTrack || GlobalTrackSDD
Int_t multTrk = tracks.size();

for (auto& track : tracks) {

Check failure on line 402 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

Double_t trackpt = track.pt();
Double_t tracketa = track.eta();
Expand Down Expand Up @@ -438,7 +438,7 @@
histos.fill(HIST("QynC"), v0Centr, QynGapC / multGapC);
}

for (auto& track : tracks) {

Check failure on line 441 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

Double_t trackpt = track.pt();
Double_t tracketa = track.eta();
Expand All @@ -465,14 +465,14 @@

if (crsRowsFrcShCls) {
Float_t nrowscr = track.tpcNClsCrossedRows();
if (nrowscr < 120)

Check failure on line 468 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;

Float_t clsFind = track.tpcNClsFindable();
if (clsFind <= 0)
continue;

if (track.tpcCrossedRowsOverFindableCls() < 0.9)

Check failure on line 475 in Tutorials/OpenData/flowAnalysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
}

Expand Down
Loading