Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions DPG/Tasks/AOTTrack/PID/Combined/qaPIDWithV0s.cxx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in DPG/Tasks/AOTTrack/PID/Combined/qaPIDWithV0s.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file]

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -16,18 +16,21 @@
/// \brief Task to monitor the PID performance making use of V0s
///

#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/ASoAHelpers.h"
#include "ReconstructionDataFormats/Track.h"
#include "Common/Core/RecoDecay.h"
#include "Common/Core/trackUtilities.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

#include "Common/Core/RecoDecay.h"
#include "Common/Core/TrackSelection.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/ASoAHelpers.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Track.h"

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -179,7 +182,7 @@
return;
}
fillHistogram("evsel", 2.);
for (auto& trk : tracks) {

Check failure on line 185 in DPG/Tasks/AOTTrack/PID/Combined/qaPIDWithV0s.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
fillHistogram("tracks", 1.f);
if (trk.sign() > 0) {
fillHistogram("tracks", 2.f);
Expand All @@ -197,7 +200,7 @@
}
}

for (auto& v0 : fullV0s) {

Check failure on line 203 in DPG/Tasks/AOTTrack/PID/Combined/qaPIDWithV0s.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop]

Use constant references for non-modified iterators in range-based for loops.
fillHistogram("v0s", 1.);
if (!acceptV0s(v0, collision)) {
continue;
Expand Down
3 changes: 2 additions & 1 deletion DPG/Tasks/AOTTrack/PID/HMPID/hmpidTableProducer.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/TableProducer/PID/pidTOFBase.h"

Expand Down
3 changes: 2 additions & 1 deletion DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file]

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -15,8 +15,9 @@
///

#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseITS.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/AnalysisTask.h"
Expand Down Expand Up @@ -215,7 +216,7 @@

histos.add("event/vertexz", "", kTH1D, {vtxZAxis});
h = histos.add<TH1>("event/particlehypo", "", kTH1D, {{10, 0, 10, "PID in tracking"}});
for (int id = 0; id < 9; id++) {

Check failure on line 219 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
h->GetXaxis()->SetBinLabel(id + 1, PID::getName(id));
tpcSelValues[id] = tpcSelection->get(tableNames[id].c_str(), "selection");
if (tpcSelValues[id] <= 0.f) {
Expand All @@ -233,7 +234,7 @@
histos.add("event/pt", "", kTH1D, {ptAxis});
histos.add("event/p", "", kTH1D, {pAxis});

for (int id = 0; id < 9; id++) {

Check failure on line 237 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
const int f = enabledParticle->get(tableNames[id].c_str(), "enable");
if (f != 1) {
continue;
Expand All @@ -253,7 +254,7 @@
histos.print();
}

Filter eventFilter = (o2::aod::evsel::sel8 == true && nabs(o2::aod::collision::posZ) < 10.f);

Check failure on line 257 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
// Filter trackFilter = (requireGlobalTrackInFilter());
using CollisionCandidate = soa::Filtered<soa::Join<aod::Collisions, aod::EvSels>>::iterator;
using TrackCandidates = soa::Join<aod::Tracks, aod::TracksExtra, aod::TrackSelection,
Expand Down Expand Up @@ -308,7 +309,7 @@
histos.fill(HIST("event/averageClusterSize"), track.p(), averageClusterSizeTrk(track));
histos.fill(HIST("event/averageClusterSizePerCoslInv"), track.p(), averageClusterSizePerCoslInv(track));
bool discard = false;
for (int id = 0; id < 9; id++) {

Check failure on line 312 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if (std::abs(nsigmaTPC(track, id)) > tpcSelValues[id]) {
LOG(debug) << "Discarding based on TPC hypothesis " << id << " " << std::abs(nsigmaTPC(track, id)) << ">" << tpcSelValues[id];
discard = true;
Expand All @@ -333,7 +334,7 @@
continue;
}
if (applyRapidityCut) {
if (std::abs(track.rapidity(PID::getMass(id))) > 0.5) {

Check failure on line 337 in DPG/Tasks/AOTTrack/PID/ITS/qaPIDITS.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
}
}
Expand Down
10 changes: 6 additions & 4 deletions DPG/Tasks/AOTTrack/PID/TPC/qaPIDTPC.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@
/// \brief Implementation for QA tasks of the TPC PID quantities
///

#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "Framework/HistogramRegistry.h"
#include "Framework/StaticFor.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Framework/runDataProcessing.h"

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -252,7 +254,7 @@

histos.add("event/vertexz", "", kTH1D, {vtxZAxis});
h = histos.add<TH1>("event/particlehypo", "", kTH1D, {{10, 0, 10, "PID in tracking"}});
for (int i = 0; i < 9; i++) {

Check failure on line 257 in DPG/Tasks/AOTTrack/PID/TPC/qaPIDTPC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
h->GetXaxis()->SetBinLabel(i + 1, PID::getName(i));
}
if (enableDeDxPlot) {
Expand Down
23 changes: 13 additions & 10 deletions DPG/Tasks/AOTTrack/V0Cascades/qaCascades.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,23 @@
/// \brief QA task for basic quantities on cascades
///

#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/ASoAHelpers.h"
#include "ReconstructionDataFormats/Track.h"
#include "Common/Core/RecoDecay.h"
#include "Common/Core/trackUtilities.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

#include "Common/Core/RecoDecay.h"
#include "Common/Core/TrackSelection.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/ASoAHelpers.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Track.h"

using namespace o2;
using namespace o2::framework;
Expand Down
21 changes: 12 additions & 9 deletions DPG/Tasks/AOTTrack/V0Cascades/qaK0sTrackingEfficiency.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,21 @@
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

#include "Framework/runDataProcessing.h"
#include "Framework/AnalysisTask.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/ASoAHelpers.h"
#include "ReconstructionDataFormats/Track.h"
#include "Common/Core/RecoDecay.h"
#include "Common/Core/trackUtilities.h"
#include "PWGLF/DataModel/LFStrangenessTables.h"

#include "Common/Core/RecoDecay.h"
#include "Common/Core/TrackSelection.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/ASoAHelpers.h"
#include "Framework/AnalysisDataModel.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/Track.h"

using namespace o2;
using namespace o2::framework;
Expand Down
3 changes: 2 additions & 1 deletion DPG/Tasks/AOTTrack/tagAndProbeDmesons.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/CollisionAssociationTables.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Tools/ML/MlResponse.h"

Expand Down
3 changes: 2 additions & 1 deletion DPG/Tasks/ITS/filterTracks.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/CollisionAssociationTables.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "Framework/ASoA.h"
Expand Down
14 changes: 8 additions & 6 deletions DPG/Tasks/TOF/tofOfflineCalib.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@
/// \brief Task to produce calibration objects for the TOF. Based on AO2D or TOF skimmed data
///

#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "tofSkimsTableCreator.h"

#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/FT0Corrected.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

#include "tofSkimsTableCreator.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"

using namespace o2;
using namespace o2::framework;
Expand Down
3 changes: 2 additions & 1 deletion DPG/Tasks/TPC/tpcSkimsTableCreator.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/OccupancyTables.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseITS.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/TableProducer/PID/pidTPCBase.h"

Expand Down
13 changes: 8 additions & 5 deletions DPG/Tasks/TPC/tpcTreeCreatorLight.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
/// \author Jeremy Wilkinson <jeremy.wilkinson@cern.ch>

#include "tpcTreeCreatorLight.h"

#include <CCDB/BasicCCDBManager.h>

#include <cmath>
/// ROOT
#include "TRandom3.h"
Expand All @@ -27,10 +29,11 @@
#include "Framework/runDataProcessing.h"
/// O2Physics
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/TrackSelectionTables.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/TrackSelectionTables.h"

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -197,8 +200,8 @@ struct TreeWriterTPCTOF {
}

} /// Loop tracks
} /// process
}; /// struct TreeWriterTPCTOF
} /// process
}; /// struct TreeWriterTPCTOF

WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
Expand Down
Loading