Skip to content

[ALICE3] Clean PIDResponse in ALICE3 #13637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Nov 2, 2025
+15 −12
Merged

[ALICE3] Clean PIDResponse in ALICE3 #13637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ALICE3/Tasks/ECALqa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in ALICE3/Tasks/ECALqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -17,12 +17,12 @@
///

// O2 includes
#include "Framework/AnalysisTask.h"
#include "ALICE3/DataModel/ECAL.h"
#include "Common/DataModel/PIDResponse.h"
#include "ReconstructionDataFormats/PID.h"

#include "Framework/AnalysisTask.h"
#include "Framework/HistogramRegistry.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/PID.h"

using namespace o2;
using namespace o2::track;
Expand All @@ -35,9 +35,9 @@
namespace indices
{
DECLARE_SOA_INDEX_COLUMN(Track, track);
DECLARE_SOA_INDEX_COLUMN(ECAL, ecal);

Check failure on line 38 in ALICE3/Tasks/ECALqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.

DECLARE_SOA_INDEX_COLUMN(McParticle, mcparticle);

Check failure on line 40 in ALICE3/Tasks/ECALqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-column] 

Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.

} // namespace indices

Expand Down Expand Up @@ -78,7 +78,7 @@
const aod::ECALs&,
const aod::Collisions&)
{
for (auto& particle : mcParticles) {

Check failure on line 81 in ALICE3/Tasks/ECALqa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (!particle.has_ecal())
continue;
histos.fill(HIST("energy"), particle.ecal().e());
Expand Down
16 changes: 9 additions & 7 deletions ALICE3/Tasks/alice3-cdeuteron.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,17 @@
/// \author Alexander Kalweit <alexander.kalweit@cern.ch>, CERN

// O2 includes
#include "Common/Core/RecoDecay.h"
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/PIDResponseTOF.h"

#include "DCAFitter/DCAFitterN.h"
#include "Framework/AnalysisTask.h"
#include "Framework/runDataProcessing.h"
#include "TLorentzVector.h"
#include "Framework/HistogramRegistry.h"
#include "Framework/runDataProcessing.h"
#include "ReconstructionDataFormats/PID.h"
#include "Common/Core/RecoDecay.h"
#include "DCAFitter/DCAFitterN.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/Core/trackUtilities.h"

#include "TLorentzVector.h"

using namespace o2;
using namespace o2::framework;
Expand Down Expand Up @@ -244,7 +246,7 @@
}
}
if constexpr (usePID) {
if (abs(track1.tofNSigmaDe()) > maxNsigmaDe || track1.sign() < 0.f) {

Check failure on line 249 in ALICE3/Tasks/alice3-cdeuteron.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
continue;
}
histos.fill(HIST("event/nsigmaDecut"), track1.pt(), track1.tofNSigmaDe());
Expand Down Expand Up @@ -274,7 +276,7 @@
}
}
if constexpr (usePID) {
if (abs(track2.tofNSigmaKa()) > maxNsigmaKa || track2.sign() > 0.f) {

Check failure on line 279 in ALICE3/Tasks/alice3-cdeuteron.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
continue;
}
histos.fill(HIST("event/nsigmaKacut"), track2.pt(), track2.tofNSigmaKa());
Expand Down Expand Up @@ -305,19 +307,19 @@
}
}
if constexpr (usePID) {
if (abs(track3.tofNSigmaPi()) > maxNsigmaPi || track3.sign() < 0.f) {

Check failure on line 310 in ALICE3/Tasks/alice3-cdeuteron.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
continue;
}
histos.fill(HIST("event/nsigmaPicut"), track3.pt(), track3.tofNSigmaPi());
}
bool iscut = false;
if (abs(dca1[0]) < minDca || abs(dca1[1]) < minDca) {

Check failure on line 316 in ALICE3/Tasks/alice3-cdeuteron.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
iscut = true;
}
if (abs(dca1[0]) < minDcaDeuteron || abs(dca1[1]) < minDcaDeuteron) {

Check failure on line 319 in ALICE3/Tasks/alice3-cdeuteron.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
iscut = true;
}
if (abs(dca1[0]) > maxDca || abs(dca1[1]) > maxDca) {

Check failure on line 322 in ALICE3/Tasks/alice3-cdeuteron.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
iscut = true;
}

Expand Down Expand Up @@ -468,7 +470,7 @@

// fitterCasc.getTrack(1).getPxPyPzGlo(pvecbach);
} // End loop on pions
} // End loop on kaons
} // End loop on kaons
histos.fill(HIST("event/candperdeuteron"), ncand);
} // End loop on deuterons
}
Expand Down
5 changes: 3 additions & 2 deletions ALICE3/Tasks/pidRICHqa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
///

// O2 includes
#include "Framework/AnalysisTask.h"
#include "ALICE3/DataModel/RICH.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/PIDResponseTOF.h"

#include "Framework/AnalysisTask.h"
#include "ReconstructionDataFormats/PID.h"

using namespace o2;
Expand Down
Loading