Skip to content

Conversation

@ariedel-cern
Copy link
Collaborator

Fix close pair rejection such that edge cases are handled correctly, i.e.

  • all angles are now explicity constrained to 0 to 2pi and angle differences are constrained to -pi to pi
  • if a track does not reach a radius at which the difference is computed, this values is not considered when applying CPR

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern ariedel-cern merged commit 2f72bc4 into AliceO2Group:master Oct 31, 2025
13 checks passed
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
auto negDaughter = cascade.template negDau_as<T3>();
auto bachelor = trackTable.rawIteratorAt(cascade.bachelorId() - trackTable.offset());
auto posDaughter = trackTable.rawIteratorAt(cascade.posDauId() - trackTable.offset());
auto negDaughter = trackTable.rawIteratorAt(cascade.posDauId() - trackTable.offset());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariedel-cern Still there

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #14177

lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants