Skip to content

Conversation

@lubynets
Copy link
Contributor

  1. In evaluation of the swapping flag the case of $\Xi^+_c\rightarrow pK^-\pi^+$ decay was missing. This PR fixes it.
  2. Removed Only from names of keep variables for signal, background and correlated background, since it is wrong (keeps are connected with logical OR).
  3. Reflected $\Lambda^+_c\rightarrow pK^-\pi^+$ added into a definition of correlated background.

@github-actions
Copy link

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 8 disabled

@github-actions github-actions bot changed the title Bugfixes of correlated background processing in 3-prong decays [PWGHF] Bugfixes of correlated background processing in 3-prong decays Oct 30, 2025
@mfaggin mfaggin merged commit 9283357 into AliceO2Group:master Oct 31, 2025
12 checks passed
@vkucera
Copy link
Collaborator

vkucera commented Oct 31, 2025

@lubynets @mfaggin I think point 2 was not a good move because it fixes the "intent vs behaviour" mismatch at the wrong place.
AFAIK, the purpose of the keepOnly... configurables was indeed to store only a given subset of candidates. If the code behaviour doesn't match the intent, it is the code behaviour that needs to be fixed, not the names that communicate the intent.

@lubynets
Copy link
Contributor Author

Hi @vkucera, I think after adding correlated BG by Mattia it is fully possible situation (from my experience) when one needs to save 2 out of 3 species - e.g. signal for efficiency determination and corrBG for its impact study. When there were only two "keeps", signal and BG, of course it did not make sense to enable both, but now it makes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants