[Common] TPC interface: skipTPCOnly auto mode, fix Run 2 bug #13604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evaluation on/off
|
O2 linter results: ❌ 21 errors, |
ddobrigk
requested review from
a team,
alibuild,
iarsene,
jgrosseo and
ktf
as code owners
Collaborator
Author
|
tested to work just fine, going to review to allow for code test via CI |
added 2 commits
October 30, 2025 23:03
auto-merge was automatically disabled
October 31, 2025 04:31
Pull request was converted to draft
ddobrigk
changed the title
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…Group#13604) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
…Group#13604) Co-authored-by: David Dobrigkeit Chinellato <david.dobrigkeit.chinellato.cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds a new mode "-1" to the skipTPCOnly configurable of the TPC PID functionality, such that it will calculate the dEdx for TPC-only tracks only in case specific tasks that require it are detected. The rationale is to allow for a single hyperloop core service wagon to be used while still saving the CPU required to evaluate the Nsigma for TPC-only if not needed.
Fixes a Run 2 crash by correctly capturing the attempt to access a CCDB object for Run 2 converted data.