[PWGHF] Add UPC process functions to taskDplus and taskD0 #13603

minjungkim12 · 2025-10-30T13:48:12Z

Summary

This PR adds Ultra-Peripheral Collision (UPC) analysis functionality to taskDplus and taskD0, following the implementation pattern from taskLc (commit 41d60bb).

Changes

Core UPC Implementation

✅ Add UPC process functions (processDataWithDCAFitterNMlWithUpc for taskD0, processDataWithMlWithUpc for taskDplus)
✅ Refactor UPC utilities to PWGHF/Utils/utilsUpcHf.h with gap type enum and helper functions
✅ Add QA histograms for UPC analysis (FIT signals, ZDC energy, gap types)
✅ Add FT0A, FT0C amplitudes and gap type axes to THnSparse
✅ Unify THnSparse structure between taskD0 and taskDplus for consistency

Configurable Thresholds and Occupancy Storage (Latest)

✅ Add configurable parameters for UPC gap determination thresholds:
- upcFT0AThreshold (default: 100.0 a.u.)
- upcFT0CThreshold (default: 50.0 a.u.)
- upcZDCThreshold (default: 1.0 a.u.)
✅ Enable storeOccupancyAndIR for UPC process in taskD0
✅ Add occupancy calculation in taskDplus UPC process
✅ Allow users to optimize gap selection criteria via JSON configuration

Benefits

Enables UPC studies for D0 and D+ mesons in Run 3
Provides configurable thresholds for different beam conditions and physics requirements
Supports occupancy and interaction rate studies in UPC analyses
Maintains consistency with taskLc approach for occupancy handling
Uses centralized utilities for code maintainability

Gap Determination Logic

Single-sided gaps are identified based on FIT and ZDC signals:

Gap on A-side: FT0A < threshold, FT0C > threshold, ZNA < threshold, ZNC > threshold
Gap on C-side: FT0A > threshold, FT0C < threshold, ZNA > threshold, ZNC < threshold
Double gap (or no clear gap): All other cases

Default thresholds are defined in utilsUpcHf.h and can be overridden via configuration.

github-actions · 2025-10-30T13:48:28Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#13603

zhangbiao-phy · 2025-10-31T07:50:52Z

hi @minjungkim12, Thanks a lot for the implementations! Given we already loose the selection on the FIT amplitudes in the derived data, and we want to determine the gap type for the candidates come from offline. In this case, We need to save the FIT signal amplitudes to the ThnSparse as we discussed. it will make the analysis more flexible. What do you think? I think @Rrantu is also working it on the Lc task

minjungkim12 · 2025-10-31T11:04:46Z

hi @minjungkim12, Thanks a lot for the implementations! Given we already loose the selection on the FIT amplitudes in the derived data, and we want to determine the gap type for the candidates come from offline. In this case, We need to save the FIT signal amplitudes to the ThnSparse as we discussed. it will make the analysis more flexible. What do you think? I think @Rrantu is also working it on the Lc task

Hi @zhangbiao-phy Thanks a lot for bringing it up! Yes, I agree with it. I will wait for the PR from @Rrantu and implement accordingly :) @Rrantu , Can I get rough time estimating?

Rrantu · 2025-11-03T06:12:40Z

Hi @minjungkim12, sorry for the late reply. I’m currently busy with meetings, but I’ll try to get this PR done before the weekend.

PWGHF/Utils/utilsUpcHf.h

PWGHF/D2H/Tasks/taskD0.cxx

minjungkim12 · 2025-11-17T16:45:16Z

Thanks a lot @zhangbiao-phy for your review :) I implemented your latest comments in my last commit.

zhangbiao-phy · 2025-11-17T16:50:31Z

Thanks a lot @zhangbiao-phy for your review :) I implemented your latest comments in my last commit.

Thanks @minjungkim12! I don't have further comments. Let's see whether Vit have further comments

alibuild · 2025-11-17T17:52:14Z

Error while checking build/O2Physics/o2 for b2ba951 at 2025-11-17 18:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13603-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:1173:66: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/13603-slc9_x86-64/0/PWGHF/D2H/Tasks/taskD0.cxx:1186:68: error: unused parameter 'tracks' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2025-11-17T17:55:17Z

Thanks a lot @zhangbiao-phy for your review :) I implemented your latest comments in my last commit.

Thanks @minjungkim12! I don't have further comments. Let's see whether Vit have further comments

Yes, I do. See my previous unresolved comments. Plus the PR doesn't compile. @minjungkim12 You are supposed to check your compilation log before pushing.

PWGHF/Utils/utilsUpcHf.h

vkucera · 2025-11-17T18:03:39Z

@zhangbiao-phy Please mark your comments as resolved if they are.

@vkucera

… warnings - Remove gapTypeToInt pass-through function from utilsUpcHf.h - Replace hf_upc::gapTypeToInt(gap) calls with gap directly in taskD0 and taskDplus - Add /*tracks*/ comment to suppress unused parameter warnings in UPC process functions The gapTypeToInt function was a no-op that simply returned its input unchanged. As noted by @vkucera, this function serves no purpose since gap is already an int. 🤖 Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

vkucera · 2025-11-18T15:54:19Z

@minjungkim12 Looks good to me. Thanks a lot for your patience and for the effort to address all the comments.
@zhangbiao-phy Can you please check as well?

zhangbiao-phy · 2025-11-18T16:05:51Z

@minjungkim12 Looks good to me. Thanks a lot for your patience and for the effort to address all the comments. @zhangbiao-phy Can you please check as well?

Green light from my side! Thanks a lot!

vkucera · 2025-11-19T12:32:26Z

@minjungkim12 Your last commit introduced a warning. Please fix it.

satisfies the naming guidelines

…up#13603)

minjungkim12 requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, stefanopolitano, vkucera and zhangbiao-phy as code owners October 30, 2025 13:48

github-actions bot added the pwghf PWG-HF label Oct 30, 2025

alibuild mentioned this pull request Oct 30, 2025

Please consider the following formatting changes to #13603 minjungkim12/O2Physics#1

Merged

vkucera marked this pull request as draft October 30, 2025 13:58

minjungkim12 added a commit to minjungkim12/O2Physics that referenced this pull request Oct 30, 2025

Merge pull request #1 from alibuild/alibot-cleanup-13603

c009341

Please consider the following formatting changes to AliceO2Group#13603

minjungkim12 marked this pull request as ready for review October 30, 2025 20:27

minjungkim12 marked this pull request as draft November 7, 2025 15:36

vkucera reviewed Nov 7, 2025

View reviewed changes

minjungkim12 marked this pull request as ready for review November 10, 2025 19:43

minjungkim12 force-pushed the add-upc-to-taskDplus branch from 9d4c45b to 6cef4e6 Compare November 12, 2025 15:37

vkucera reviewed Nov 12, 2025

View reviewed changes

PWGHF/D2H/Tasks/taskD0.cxx Outdated Show resolved Hide resolved

vkucera reviewed Nov 12, 2025

View reviewed changes

PWGHF/D2H/Tasks/taskD0.cxx Outdated Show resolved Hide resolved

zhangbiao-phy previously approved these changes Nov 17, 2025

View reviewed changes

minjungkim12 requested a review from vkucera November 17, 2025 16:58

vkucera marked this pull request as draft November 17, 2025 17:55

vkucera reviewed Nov 17, 2025

View reviewed changes

PWGHF/Utils/utilsUpcHf.h Outdated Show resolved Hide resolved

minjungkim12 and others added 2 commits November 17, 2025 19:33

fix handling unused paramemeter

d602110

minjungkim12 dismissed zhangbiao-phy’s stale review via d602110 November 18, 2025 12:39

fix auto to const auto &

5bfc554

vkucera marked this pull request as ready for review November 18, 2025 15:52

zhangbiao-phy previously approved these changes Nov 18, 2025

View reviewed changes

zhangbiao-phy enabled auto-merge (squash) November 18, 2025 16:14

Fix HIST macro usage in lambda by moving to constexpr variable

5baf9ab

auto-merge was automatically disabled November 18, 2025 23:11
Head branch was pushed to by a user without write access

minjungkim12 dismissed zhangbiao-phy’s stale review via 5baf9ab November 18, 2025 23:11

zhangbiao-phy enabled auto-merge (squash) November 19, 2025 09:27

Rename kHSparseMass to HSparseMass

b6d19c9

satisfies the naming guidelines

auto-merge was automatically disabled November 19, 2025 12:46
Head branch was pushed to by a user without write access

zhangbiao-phy enabled auto-merge (squash) November 19, 2025 19:44

stefanopolitano approved these changes Nov 20, 2025

View reviewed changes

zhangbiao-phy merged commit 32e9809 into AliceO2Group:master Nov 21, 2025
14 checks passed

yakparo pushed a commit to yakparo/O2Physics that referenced this pull request Nov 21, 2025

[PWGHF] Add UPC process functions to taskDplus and taskD0 (AliceO2Gro…

44fd622

…up#13603)

lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025

[PWGHF] Add UPC process functions to taskDplus and taskD0 (AliceO2Gro…

a7c18f3

…up#13603)

[PWGHF] Add UPC process functions to taskDplus and taskD0 #13603

[PWGHF] Add UPC process functions to taskDplus and taskD0 #13603

Uh oh!

Conversation

minjungkim12 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Core UPC Implementation

Configurable Thresholds and Occupancy Storage (Latest)

Benefits

Gap Determination Logic

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangbiao-phy commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

minjungkim12 commented Oct 31, 2025

Uh oh!

Rrantu commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

minjungkim12 commented Nov 17, 2025

Uh oh!

zhangbiao-phy commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Nov 17, 2025

Uh oh!

vkucera commented Nov 17, 2025

Uh oh!

Uh oh!

vkucera commented Nov 17, 2025

Uh oh!

vkucera commented Nov 18, 2025

Uh oh!

zhangbiao-phy commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkucera commented Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

minjungkim12 commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

zhangbiao-phy commented Oct 31, 2025 •

edited

Loading

zhangbiao-phy commented Nov 17, 2025 •

edited

Loading

zhangbiao-phy commented Nov 18, 2025 •

edited

Loading