Skip to content

[PWGLF] rapidity check added in the mc particle processing #13598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maciacco merged 3 commits into from
Nov 2, 2025
Merged

[PWGLF] rapidity check added in the mc particle processing #13598

maciacco merged 3 commits into from
Nov 2, 2025

Conversation

@GiorgioAlbertoLucia
Copy link
Contributor

@GiorgioAlbertoLucia GiorgioAlbertoLucia commented Oct 30, 2025

added rapidity check in mc particle processing and moved to a switch-case logic for flag particle setting

@github-actions github-actions bot added the pwglf label Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

O2 linter results: ❌ 7 errors, ⚠️ 6 warnings, 🔕 0 disabled

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review October 31, 2025 10:31
@alibuild
Copy link
Collaborator

alibuild commented Oct 31, 2025

Error while checking build/O2Physics/o2 for 40c862a at 2025-10-31 12:23:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
/sw/SOURCES/O2Physics/13598-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:257:25: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/13598-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:259:25: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/13598-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:261:25: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/13598-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:263:25: error: this statement may fall through [-Werror=implicit-fallthrough=]
/sw/SOURCES/O2Physics/13598-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:265:25: error: this statement may fall through [-Werror=implicit-fallthrough=]
ninja: build stopped: subcommand failed.

Full log here.

@maciacco maciacco merged commit c6de465 into AliceO2Group:master Nov 2, 2025
11 of 12 checks passed
@GiorgioAlbertoLucia GiorgioAlbertoLucia deleted the nucleiqc branch November 2, 2025 18:51
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@GiorgioAlbertoLucia @ThePhDane
[PWGLF] rapidity check added in the mc particle processing (AliceO2Gr…
15fd1d1 
…oup#13598)
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@GiorgioAlbertoLucia
[PWGLF] rapidity check added in the mc particle processing (AliceO2Gr…
c5cbad3 
…oup#13598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciacco maciacco maciacco approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GiorgioAlbertoLucia @alibuild @maciacco