[PWGCF] : Update flowEventPlane.cxx #13578
Conversation
Added gain calibrations
yashpatley
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it but consider the following
When the jobs corresponding to your task execute on the grid they will only address part of a single run each. This means your task will not change run number but the first time a collision is analyzed. Of course you cannot give for granted what I said because it is not fully enforced but say that it is what is used to happen. In its turn, this will mean that a processing is repeated for each collision producing exactly the same result which is a waste of resources.
I would recommend doing only that processing if the run number has changed with an incoming collision. An initialization to zero will address the first collision that will bring a new run number and the check of changing run number will address a potential local test with data files coming from different runs
2 participants
Added gain calibrations