Skip to content

Conversation

@ercolessi
Copy link
Collaborator

Hi @ddobrigk!

I’ve been asked to produce a calibration for the LF MC centrality for OO.
To do this, I’ll need some updates to the old centrality task (these histograms were not ported to the new multCent task).

Given the urgency (Alice Physics Week), I’d like to request these changes now if you agree. However, as we discussed previously, I am happy to chat on how to handle this more efficiently going forward. 🙂

Thanks a lot!

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

O2 linter results: ❌ 2 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ddobrigk
Copy link
Collaborator

Hi @ercolessi, thanks, of course no objection - though note that the compiler is shouting due to some missing semicolons, I believe. Can you please take a look? I can approve once fixed. Then for the rest indeed at some point we should check how to best move forward :-)

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for c4eea82 at 2025-10-25 16:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13543-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:119:76: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/13543-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:259:132: error: expected ')' before '}' token
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 34f9154 at 2025-10-25 18:13:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13543-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:119:79: error: expected ';' at end of member declaration
/sw/SOURCES/O2Physics/13543-slc9_x86-64/0/Common/TableProducer/centralityTable.cxx:261:3: error: expected ')' before '}' token
ninja: build stopped: subcommand failed.

Full log here.

@ddobrigk ddobrigk enabled auto-merge (squash) October 27, 2025 11:52
@ercolessi
Copy link
Collaborator Author

Hi @ddobrigk indeed my apologies it was a silly mistake, thanks for the approval!

@ddobrigk ddobrigk merged commit 5bcb710 into master Oct 27, 2025
13 of 15 checks passed
@ddobrigk ddobrigk deleted the ercolessi-patch-1 branch October 27, 2025 20:24
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
…tions (AliceO2Group#13543)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
…tions (AliceO2Group#13543)

Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants