[PWGEM,PWGEM-36] Update EMCal flow task to use TProfile3D #13528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mhemmer-cern
commented
Oct 24, 2025
mhemmer-cern
commented
- Instead of using 4D THnSparse to get for a specific pT and cent the 2D v_n vs m_inv histogram to then make a TProfile to average over the v_n, directly use a TProfile3D, reducing the dimensions and making sure that there are no issues for calculating <v_n> from discretizing v_n.
- Similar for the spReso plots where only the <Q_A * Q_B> vs cent is needed: instead of using 2D histogram its now a TProfile
- Instead of using 4D THnSparse to get for a specific pT and cent the 2D v_n vs m_inv histogram to then make a TProfile to average over the v_n, directly use a TProfile3D, reducing the dimensions and making sure that there are no issues for calculating <v_n> from discretizing v_n. - Similar for the spReso plots where only the <Q_A * Q_B> vs cent is needed: instead of using 2D histogram its now a TProfile
mhemmer-cern
requested review from
alibuild,
dsekihat,
m-c-danisch,
mikesas,
novitzky and
rbailhac
as code owners
|
O2 linter results: ❌ 0 errors, |
alibuild
previously approved these changes
Oct 24, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
- Fix missing removal of `thnAxisScalarProd` for `hSparseFlow`
alibuild
approved these changes
Oct 24, 2025
Collaborator
alibuild
left a comment
alibuild
left a comment
There was a problem hiding this comment.
Auto-approving on behalf of @mhemmer-cern.
Collaborator
|
Error while checking build/O2Physics/o2 for e3b7081 at 2025-10-24 21:34: Full log here. |
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.