[PWGDQ] Removing useless template for table-maker-mc-with-assoc #13527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucamicheletti93
requested review from
alibuild,
iarsene and
mcoquet642
as code owners
|
O2 linter results: ❌ 77 errors, |
iarsene
reviewed
Oct 24, 2025
| for (auto& mcCollision : mcCollisions) { | ||
| // Get MC collision information into the VarManager | ||
| VarManager::FillEvent<TEventMcFillMap>(mcCollision); | ||
| VarManager::FillEvent<gkEventMcFillMapWithCent>(mcCollision); |
Collaborator
There was a problem hiding this comment.
in the spirit of what we discussed, I think also this MC event fill map is not needed. We can fill everything just under the CollisionMC, which we can hardcode, as before
Collaborator
Author
There was a problem hiding this comment.
Thanks @iarsene ! I have restored the old CollisionMC adding the centrality information
Collaborator
Author
There was a problem hiding this comment.
@iarsene I have restored the previous version becasue the change you propose implise modification also in the EM framework. For this reason I restored the previous code.
Collaborator
|
Error while checking build/O2Physics/o2 for 7e2f92b at 2025-10-24 22:43: Full log here. |
iarsene
approved these changes
Oct 27, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…eO2Group#13527) Co-authored-by: Lucamicheletti93 <luca.mike93@gmail.com>
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
…eO2Group#13527) Co-authored-by: Lucamicheletti93 <luca.mike93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing useless template for table-maker-mc-with-assoc