Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Oct 23, 2025

No description provided.

@github-actions
Copy link

O2 linter results: ❌ 4 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Remove unused ONNX dependency [PWGHF,Trigger] Remove unused ONNX dependency Oct 23, 2025
@vkucera vkucera marked this pull request as ready for review October 23, 2025 15:35
@zhangbiao-phy
Copy link
Collaborator

Thanks @vkucera

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) October 24, 2025 13:31
@fgrosa
Copy link
Collaborator

fgrosa commented Oct 24, 2025

Hi @vkucera, did you test this? In the past, not having it in the CMakeList.cxx was causing a crash of the filters runtime (that's why it's there)

@fgrosa fgrosa disabled auto-merge October 24, 2025 14:34
@vkucera
Copy link
Collaborator Author

vkucera commented Oct 24, 2025

Hi @vkucera, did you test this? In the past, not having it in the CMakeList.cxx was causing a crash of the filters runtime (that's why it's there)

Hi @fgrosa , I admit I haven't tested it. If you give me a hint about a proper setup, I can run it locally.
Which part of the code would need ONNX? I don't see any.

@fgrosa
Copy link
Collaborator

fgrosa commented Oct 24, 2025

Hi @vkucera, did you test this? In the past, not having it in the CMakeList.cxx was causing a crash of the filters runtime (that's why it's there)

Sorry for the noise, I now realised that it was before we moved the ML inference in the trackIndexSkimCreator, so indeed now it should not be an issue anymore.

@vkucera
Copy link
Collaborator Author

vkucera commented Oct 24, 2025

Hi @vkucera, did you test this? In the past, not having it in the CMakeList.cxx was causing a crash of the filters runtime (that's why it's there)

Sorry for the noise, I now realised that it was before we moved the ML inference in the trackIndexSkimCreator, so indeed now it should not be an issue anymore.

Thanks for checking!

@mpuccio mpuccio merged commit 764ec40 into AliceO2Group:master Oct 24, 2025
14 of 15 checks passed
@vkucera vkucera deleted the onnx branch October 24, 2025 16:27
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants