Skip to content

[DPG/AOTTrack/qaMatchEff] Add kNoTISROFrameBorder condition to study margin effects and linter corrections #13514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mapalhares wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[DPG/AOTTrack/qaMatchEff] Add kNoTISROFrameBorder condition to study margin effects and linter corrections #13514

mapalhares wants to merge 4 commits into from

Conversation

@mapalhares
Copy link
Contributor

@mapalhares mapalhares commented Oct 23, 2025

No description provided.

@github-actions github-actions bot added the dpg label Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025 •
edited
Loading

O2 linter results: ❌ 29 errors, ⚠️ 12 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title DPG/AOTTrack/qaMatchEff: Add kNoTISROFrameBorder condition to study margin effects and linter corrections [DPG/AOTTrack/qaMatchEff] Add kNoTISROFrameBorder condition to study margin effects and linter corrections Oct 23, 2025
@alibuild alibuild mentioned this pull request Oct 23, 2025
Merged
mapalhares added a commit to mapalhares/O2Physics that referenced this pull request Oct 23, 2025
@mapalhares
Merge pull request #52 from alibuild/alibot-cleanup-13514
cfaec46 
[DPG] Please consider the following formatting changes to AliceO2Group#13514
iouribelikov
iouribelikov reviewed Oct 24, 2025
View reviewed changes
DPG/Tasks/AOTTrack/qaMatchEff.cxx Outdated
// delta += o2::constants::math::TwoPI;
// }
// histos.get<TH1>(HIST("MC/control/phihist_diff"))->Fill(delta);
//}
Copy link
Collaborator

@iouribelikov iouribelikov Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole "if (isPhysicalPrimary)" is now commented out. Why so ?

Copy link
Contributor Author

@mapalhares mapalhares Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared to the original code, the specific condition only checks the delta value without using it elsewhere in the code. As a result, delta becomes an unused variable, so I commented to avoid compilation erros.

Copy link
Collaborator

@iouribelikov iouribelikov Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Now I see. Thank you.
But then, it may be better to uncomment all lines of this "if block".
( Including the two lines filling a couple of histograms, that were commented out already in the original code. )

Copy link
Contributor Author

@mapalhares mapalhares Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure! I'm submitting it.

@alibuild alibuild mentioned this pull request Oct 29, 2025
Merged
@mapalhares
Merge pull request #53 from alibuild/alibot-cleanup-13514
2bf2687 
[DPG] Please consider the following formatting changes to AliceO2Group#13514
vkucera
vkucera reviewed Nov 2, 2025
View reviewed changes
DPG/Tasks/AOTTrack/qaMatchEff.cxx
Comment on lines -23 to 28
#include "Common/CCDB/EventSelectionParams.h"
#include "Common/Core/RecoDecay.h"
#include "Common/Core/TrackSelection.h"
#include "Common/Core/TrackSelectionDefaults.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/PIDResponse.h"
#include "Common/DataModel/TrackSelectionTables.h"
Copy link
Collaborator

@vkucera vkucera Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are reverting fixes made in #12949

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 3, 2025
@alibuild
Copy link
Collaborator

alibuild commented Dec 3, 2025

Error while checking build/O2Physics/o2 for 2bf2687 at 2025-12-03 19:39:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:

Full log here.

@github-actions github-actions bot removed the stale label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iouribelikov iouribelikov iouribelikov left review comments

@vkucera vkucera vkucera left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dpg

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mapalhares @alibuild @iouribelikov @vkucera