Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Oct 22, 2025

Move parts of PWGHF/DataModel/CandidateReconstructionTables.h into:

  • PWGHF/DataModel/CandidateSkimmingTables.h
    • Tables and flags used in the track index skimming
  • PWGHF/DataModel/AliasTables.h
    • Definitions of joined table types
  • PWGHF/Core/DecayChannelsLegacy.h
    • Legacy MC flags that should be replaced.
  • PWGHF/ALICE3/Core/DecayChannelsLegacy.h
    • Legacy MC flags used only for ALICE3.

The goal is to factorise header dependencies and to reduce recompilations when modifying parts of the data model.

@vkucera vkucera changed the title Divide data model into skimming, reconstruction, aliases Divide canidate data model into skimming, reconstruction, aliases Oct 22, 2025
@vkucera vkucera changed the title Divide canidate data model into skimming, reconstruction, aliases Divide candidate data model into skimming, reconstruction, aliases Oct 22, 2025
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

O2 linter results: ❌ 112 errors, ⚠️ 24 warnings, 🔕 28 disabled

@github-actions github-actions bot changed the title Divide candidate data model into skimming, reconstruction, aliases [PWGHF,Trigger] Divide data model into skimming, reconstruction, aliases Oct 22, 2025
@github-actions github-actions bot changed the title [PWGHF,Trigger] Divide data model into skimming, reconstruction, aliases [PWGHF,Trigger] Divide canidate data model into skimming, reconstruction, aliases Oct 22, 2025
@github-actions github-actions bot changed the title [PWGHF,Trigger] Divide canidate data model into skimming, reconstruction, aliases [PWGHF,Trigger] Divide candidate data model into skimming, reconstruction, aliases Oct 22, 2025
@github-actions github-actions bot added the pwgje label Oct 23, 2025
@vkucera vkucera changed the title [PWGHF,Trigger] Divide candidate data model into skimming, reconstruction, aliases Divide candidate data model into skimming, reconstruction, aliases Oct 23, 2025
@github-actions github-actions bot changed the title Divide candidate data model into skimming, reconstruction, aliases [PWGHF,PWGJE,Trigger] Divide candidate data model into skimming, reconstruction, aliases Oct 23, 2025
@vkucera vkucera marked this pull request as ready for review October 23, 2025 15:25
/// \author Gian Michele Innocenti <gian.michele.innocenti@cern.ch>, CERN
/// \author Vít Kučera <vit.kucera@cern.ch>, CERN

#ifndef PWGHF_DATAMODEL_CANDIDATESKIMMINGTABLES_H_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would refrain from using the term "skimming" to avoid confusion, since in ALICE skimming is referring to the software triggers (I know that we called "skimCreator" our HF vertex finder, but this would also not be a proper name, since we are not skimming anything, but actually adding information to the AO2Ds). I propose to use the TrackIndexSkimCreatorTables.h or something similar, to make it a bit more clear that it refers to the trackIndexSkimCreator task.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The name is neither AliceSkimmingTables.h nor SkimmingTables.h, it's CandidateSkimmingTables.h. I think that makes the context clear enough.
  • Why do you say that we are not skimming anything? We are skimming the combinations of track indices which are our decay candidates.
  • Is TrackIndexSkimmingTables.h fine?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not "skimming" because if it was it, it would imply a reduction of the information while in our case we add the information of candidates starting from tracks (so it's vertex finding, similar to the SVertexer in the reconstruction). In any case I think that TrackIndexSkimmingTables makes it less ambiguous, thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgrosa Good to merge?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkucera good for me, thanks!

nzardosh
nzardosh previously approved these changes Oct 26, 2025
@vkucera vkucera marked this pull request as draft October 26, 2025 23:34
@vkucera vkucera marked this pull request as ready for review October 28, 2025 16:47
@nzardosh nzardosh self-requested a review October 31, 2025 16:17
@vkucera vkucera merged commit 2617ff2 into AliceO2Group:master Oct 31, 2025
16 of 17 checks passed
@vkucera vkucera deleted the skim-tables branch October 31, 2025 18:16
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants