[PWGCF] Charge Particle Flow #13485
Merged
[PWGCF] Charge Particle Flow #13485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charged particle flow QA from event plane.
yashpatley
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 1 errors, |
PWGCF/Flow/Tasks/flowEventPlane.cxx
Outdated
Comment on lines
284
to
286
| if (!kinCutSelection(track.pt(), std::abs(track.eta()), cTrackMinPt, cTrackMaxPt, cTrackEtaCut)) { | ||
| return false; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why not passing just the track and let the routine do the rest?
PWGCF/Flow/Tasks/flowEventPlane.cxx
Outdated
Comment on lines
491
to
492
| histos.fill(HIST("Checks/hPsiSPA"), cent, TMath::ATan2(vSP[kYa], vSP[kXa])); | ||
| histos.fill(HIST("Checks/hPsiSPC"), cent, TMath::ATan2(vSP[kYc], vSP[kXc])); |
Collaborator
There was a problem hiding this comment.
Please, fix linter warnings
PWGCF/Flow/Tasks/flowEventPlane.cxx
Outdated
Comment on lines
510
to
511
| ux = TMath::Cos(track.phi()); | ||
| uy = TMath::Sin(track.phi()); |
Collaborator
There was a problem hiding this comment.
Please, fix linter warnings
Collaborator
|
Have this code been compiled and tested locally before creating the PR? |
Updated histogram definitions and filling logic to use TProfile instead of TH3F for certain checks. Adjusted the selection criteria for tracks and modified data processing workflow.
Collaborator
|
Error while checking build/O2Physics/o2 for 56e74b2 at 2025-10-22 12:38: Full log here. |
Contributor
Author
|
@victor-gonzalez could you please have a look at the error in the PR, I think it's not related to the changes I made in the file, please let me know what to do ? Thanks. |
Collaborator
The error corresponds to a previous commit, 56e74b2, which you fixed in commit b054c29 There are no errors in the PR apart form the |
victor-gonzalez
approved these changes
Oct 23, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.