Skip to content

[PWGLF] added configurable to select physical primaries, tracks are now required to have an associated mc particle #13465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpuccio merged 6 commits into from
Oct 22, 2025
Merged

[PWGLF] added configurable to select physical primaries, tracks are now required to have an associated mc particle #13465

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c23b0e
fixed build errors spotted during the PR
GiorgioAlbertoLucia Oct 3, 2025
32f60ad
Please consider the following formatting changes
alibuild Oct 3, 2025
f71226f
fixed compilation errors spotted during PR
GiorgioAlbertoLucia Oct 3, 2025
381ddd4
clang format
GiorgioAlbertoLucia Oct 3, 2025
dc242d3
added requirement for tracks to have associated particle and to be co…
GiorgioAlbertoLucia Oct 20, 2025
a327746
clang-format
GiorgioAlbertoLucia Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 45 additions & 43 deletions PWGLF/TableProducer/QC/nucleiQC.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -76,6 +76,7 @@

Configurable<bool> cfgFillTable{"cfgFillTable", true, "Fill output tree"};
Configurable<bool> cfgDoCheckPdgCode{"cfgDoCheckPdgCode", true, "Should you only select tracks associated to a mc particle with the correct PDG code?"};
Configurable<bool> cfgFillOnlyPhysicalPrimaries{"cfgFillOnlyPhysicalPrimaries", true, "Should you only select physical primary particles?"};
Configurable<LabeledArray<int>> cfgSpeciesToProcess{"cfgSpeciesToProcess", {nuclei::speciesToProcessDefault[0], nuclei::Species::kNspecies, 1, nuclei::names, {"processNucleus"}}, "Nuclei to process"};
Configurable<LabeledArray<int>> cfgEventSelections{"cfgEventSelections", {nuclei::EvSelDefault[0], 8, 1, nuclei::eventSelectionLabels, nuclei::eventSelectionTitle}, "Event selections"};
Configurable<int> cfgCentralityEstimator{"cfgCentralityEstimator", 0, "Centrality estimator (FV0A: 0, FT0M: 1, FT0A: 2, FT0C: 3)"};
Expand All @@ -97,7 +98,7 @@

// CCDB options
Configurable<int> cfgMaterialCorrection{"cfgMaterialCorrection", static_cast<int>(o2::base::Propagator::MatCorrType::USEMatCorrLUT), "Type of material correction"};
Configurable<std::string> cfgCCDBurl{"ccdb-url", "http://alice-ccdb.cern.ch", "url of the ccdb repository"};

Check failure on line 101 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Service<o2::ccdb::BasicCCDBManager> mCcdb;
int mRunNumber = 0;
float mBz = 0.f;
Expand Down Expand Up @@ -136,21 +137,19 @@
}

for (int iSpecies = 0; iSpecies < static_cast<int>(nuclei::Species::kNspecies); iSpecies++) {
if (cfgSpeciesToProcess->get(iSpecies) == 1) {
if (cfgSpeciesToProcess->get(iSpecies) == 1)
mSpeciesToProcess.emplace_back(iSpecies);
}
}

static_for<0, nuclei::kNspecies - 1>([&](auto iSpecies) {
constexpr int kSpeciesCt = decltype(iSpecies)::value;
const int kSpeciesRt = kSpeciesCt;

if (std::find(mSpeciesToProcess.begin(), mSpeciesToProcess.end(), kSpeciesCt) == mSpeciesToProcess.end()) {
if (std::find(mSpeciesToProcess.begin(), mSpeciesToProcess.end(), kSpeciesCt) == mSpeciesToProcess.end())
return;
}

float tpcBetheBlochParams[6];
for (int iParam = 0; iParam < 6; iParam++) {

Check failure on line 152 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
tpcBetheBlochParams[iParam] = cfgBetheBlochParams->get(kSpeciesRt, iParam);
}

Expand All @@ -166,9 +165,9 @@

void initCCDB(const aod::BCsWithTimestamps::iterator& bc)
{
if (mRunNumber == bc.runNumber()) {
if (mRunNumber == bc.runNumber())
return;
}

auto timestamp = bc.timestamp();
mRunNumber = bc.runNumber();

Expand All @@ -186,10 +185,10 @@
track.tpcInnerParam() < cfgCutTpcMom ||
track.itsNCls() < cfgCutNclusITS ||
track.tpcNClsFound() < cfgCutNclusTPC ||
track.tpcNClsCrossedRows() < 70 ||

Check failure on line 188 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
track.tpcNClsCrossedRows() < 0.8 * track.tpcNClsFindable() ||

Check failure on line 189 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
track.tpcChi2NCl() > 4.f ||

Check failure on line 190 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
track.itsChi2NCl() > 36.f) {

Check failure on line 191 in PWGLF/TableProducer/QC/nucleiQC.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
return false;
}
return true;
Expand All @@ -199,9 +198,8 @@
bool pidSelection(const Ttrack& track, const Tcollision& collision)
{
constexpr int kIndex = iSpecies;
if (!nuclei::checkSpeciesValidity(kIndex)) {
if (!nuclei::checkSpeciesValidity(kIndex))
std::runtime_error("species contains invalid nucleus kIndex");
}

float centrality = nuclei::getCentrality(collision, cfgCentralityEstimator);
float nsigmaTPC = mPidManagers[kIndex].getNSigmaTPC(track);
Expand Down Expand Up @@ -266,15 +264,14 @@
: iSpecies == nuclei::Species::kAl ? nuclei::Flags::kHe4
: 0;

if (track.hasTOF()) {
if (track.hasTOF())
candidate.flags |= nuclei::Flags::kHasTOF;
}
if (track.hasTRD()) {

if (track.hasTRD())
candidate.flags |= nuclei::Flags::kHasTRD;
}
if (!collision.selection_bit(o2::aod::evsel::kNoITSROFrameBorder)) {

if (!collision.selection_bit(o2::aod::evsel::kNoITSROFrameBorder))
candidate.flags |= nuclei::Flags::kITSrof;
}
}

template <typename Tparticle>
Expand Down Expand Up @@ -304,9 +301,9 @@
template <const bool isMc, typename Tcollision, typename Ttrack>
nuclei::SlimCandidate fillCandidate(const int iSpecies, Tcollision const& collision, Ttrack const& track)
{
if (!nuclei::checkSpeciesValidity(iSpecies)) {
if (!nuclei::checkSpeciesValidity(iSpecies))
std::runtime_error("species contains invalid nucleus index");
}

nuclei::SlimCandidate candidate = {.pt = track.pt() * track.sign(),
.eta = track.eta(),
.phi = track.phi(),
Expand Down Expand Up @@ -336,7 +333,6 @@
}
}

mNucleiCandidates.emplace_back(candidate);
return candidate;
}

Expand All @@ -363,9 +359,8 @@
void fillHistograms(const nuclei::SlimCandidate& candidate)
{
constexpr int kIndex = iSpecies;
if (!nuclei::checkSpeciesValidity(kIndex)) {
if (!nuclei::checkSpeciesValidity(kIndex))
std::runtime_error("species contains invalid nucleus kIndex");
}

if (isGenerated) {
const float ptGenerated = (kIndex == nuclei::Species::kPr || kIndex == nuclei::Species::kDe || kIndex == nuclei::Species::kTr) ? candidate.ptGenerated : candidate.ptGenerated / 2.f;
Expand All @@ -392,31 +387,38 @@
auto bc = collision.template bc_as<aod::BCsWithTimestamps>();
initCCDB(bc);

if (!nuclei::eventSelection(collision, mHistograms, cfgEventSelections, cfgCutVertex)) {
if (!nuclei::eventSelection(collision, mHistograms, cfgEventSelections, cfgCutVertex))
return;
}

for (const auto& track : tracks) {

static_for<0, nuclei::kNspecies - 1>([&](auto iSpecies) {
constexpr int kSpeciesCt = decltype(iSpecies)::value;
const int kSpeciesRt = kSpeciesCt;

if (std::find(mSpeciesToProcess.begin(), mSpeciesToProcess.end(), kSpeciesRt) == mSpeciesToProcess.end()) {
if (std::find(mSpeciesToProcess.begin(), mSpeciesToProcess.end(), kSpeciesRt) == mSpeciesToProcess.end())
return;

if (!track.has_mcParticle())
return;
}

if (track.has_mcParticle()) {
const auto& particle = track.mcParticle();
if (cfgDoCheckPdgCode) {
if (std::abs(particle.pdgCode()) != nuclei::pdgCodes[kSpeciesRt])
return;
}
if ((particle.y() - cfgRapidityCenterMass) < cfgRapidityMin || (particle.y() - cfgRapidityCenterMass) > cfgRapidityMax) {
const auto& particle = track.mcParticle();
if (cfgDoCheckPdgCode) {
if (std::abs(particle.pdgCode()) != nuclei::pdgCodes[kSpeciesRt])
return;
}
}

if ((particle.y() - cfgRapidityCenterMass) < cfgRapidityMin || (particle.y() - cfgRapidityCenterMass) > cfgRapidityMax)
return;

if (cfgFillOnlyPhysicalPrimaries && !particle.isPhysicalPrimary())
return;

nuclei::SlimCandidate candidate;
candidate = fillCandidate</*isMc*/ true>(kSpeciesCt, collision, track);
if ((candidate.flags >> 10) & 0b1)
LOG(info) << "track from material before track selection";

mHistograms.fill(HIST(nuclei::cNames[kSpeciesCt]) + HIST("/hTrackSelections"), nuclei::trackSelection::kNoCuts);
if (!trackSelection(track))
return;
Expand All @@ -426,35 +428,35 @@
return;
mHistograms.fill(HIST(nuclei::cNames[kSpeciesCt]) + HIST("/hTrackSelections"), nuclei::trackSelection::kPidCuts);

nuclei::SlimCandidate candidate;
if (track.has_mcParticle()) {
candidate = fillCandidate</*isMc*/ true>(kSpeciesCt, collision, track);
dispatchFillHistograms</*isGenerated*/ true>(kSpeciesRt, candidate);
} else {
candidate = fillCandidate</*isMc*/ true>(kSpeciesCt, collision, track);
}
// nuclei::SlimCandidate candidate;
// candidate = fillCandidate</*isMc*/ true>(kSpeciesCt, collision, track);

mNucleiCandidates.emplace_back(candidate);
dispatchFillHistograms</*isGenerated*/ true>(kSpeciesRt, candidate);
dispatchFillHistograms</*isGenerated*/ false>(kSpeciesRt, candidate);
});
}

const int mcCollisionId = collision.mcCollisionId();
auto mcParticlesThisCollision = mcParticles.sliceBy(mMcParticlesPerCollision, mcCollisionId);
mcParticlesThisCollision.bindExternalIndices(&mcParticles);

for (const auto& particle : mcParticlesThisCollision) {
if (std::find(mFilledMcParticleIds.begin(), mFilledMcParticleIds.end(), particle.globalIndex()) != mFilledMcParticleIds.end()) {
if (std::find(mFilledMcParticleIds.begin(), mFilledMcParticleIds.end(), particle.globalIndex()) != mFilledMcParticleIds.end())
continue;
}

if (cfgFillOnlyPhysicalPrimaries && !particle.isPhysicalPrimary())
continue;

int iSpecies = nuclei::getSpeciesFromPdg(particle.pdgCode());
if (std::find(mSpeciesToProcess.begin(), mSpeciesToProcess.end(), iSpecies) == mSpeciesToProcess.end()) {
if (std::find(mSpeciesToProcess.begin(), mSpeciesToProcess.end(), iSpecies) == mSpeciesToProcess.end())
continue;
}

nuclei::SlimCandidate candidate;
fillNucleusFlagsPdgsMc(particle, candidate);
fillNucleusGeneratedVariables(particle, candidate);
mNucleiCandidates.emplace_back(candidate);

mNucleiCandidates.emplace_back(candidate);
dispatchFillHistograms</*isGenerated*/ true>(iSpecies, candidate);
}

Expand Down
Loading