-
Notifications
You must be signed in to change notification settings - Fork 615
[DPG] tpcSkimsTableCreator: algo bugfix; add nSigma TOF cut; code cleaning #13438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 1 errors, |
|
Hi @lubynets, sorry to ambush you a little bit, but please be mindful that primary TOF is not directly applicable for secondaries because a relatively large number of daughter prongs is associated to an incorrect collision (different than the V0 or cascade). For example, see here the rate of pions from K0 for which the pion track is in the same collision as the K0 mother:
In addition to this, the length traveled prior to decay should also be considered. To address these two factors, there is the 'strangeness tof pid' functionality (see this talk), which reassociates weak decay tracks to the collision their weakly decaying mothers are associated to and redoes the TOF calculation. It might be best to consider using that option instead, even if I'm admittedly still discussing a few details of the time re-association calculation with @njacazio (which we should hopefully sort out soon). |
|
Hi @ddobrigk, |
Hi @lubynets , yes, that's the workflow, and you in fact only need the |
|
@ddobrigk @chiarazampolli @catalinristea @alcaliva Why is DPG not respecting the workflow directory structure as defined at https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/theo2physicsrepo.html#folder-structure ? |
|
Dear code owners, could you please consider the PR? |
Dear @chiarazampolli, @alcaliva, @catalinristea, could you please check the PR and approve it or provide comments (if any)? |
Dear @alcaliva (All cc), thanks for approving the PR! Could you please merge it? |
|
Hi @lubynets I think approval is limited but clicking on merge is not, so I did it for you :-) |
Sorry for being boring, but I did not have a button "Merge" to click on it (maybe it depends on the target repository settings), that's way I asked. Thanks for merging! |
|
Ah - sorry, my bad, I think I remembered incorrectly then... |

Algorithm error fixes:
soa::Filteredhad no effect in the V0 struct. It is fixed by implementation the track selection via boolean function.Note: default track selection in the V0 struct is changed from 1 to 0 (
GlobalTracktoNoCut).Functionality enhancement:$N \sigma_{\mathrm{TOF}}$ for V0-based selected tracks and a possibility to reject tracks unmatched to TOF. Both $N \sigma_{\mathrm{TOF}}$ and a requirement to reject unmatched to TOF tracks are added as configurables - float and bool respectively, individually for all particle species.
Added a possibility to cut on
Note:
o2-analysis-lf-strangenesstofpidworkflow is required as dependency.Code cleaning:
Trackstable from passed into V0 process functions.Tagging @amaringarcia