[PWGCF] Addition of named constants in PID function #13433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction for labelled arrays
github-actions
bot
changed the title
|
O2 linter results: ❌ 0 errors, |
[PWGCF] Please consider the following formatting changes to AliceO2Group#13433
Preet-Bhanjan
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
Comment on lines
+108
to
+110
| PIONS = 0, | ||
| KAONS, | ||
| PROTONS |
Collaborator
There was a problem hiding this comment.
I still believe this is inconsistent a dangerous
Depending on the part of the code you look at this assignment is true or is false
I understand you try to use a single configurable to address identified or not particles and which of the identified particle is of interest but this clearly creates an inconsistency between parts of your code
I would suggest trying to address that situation in a different way
victor-gonzalez
approved these changes
Oct 19, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it for the time being but have a look at my comment, I believe it is worth to try a little bit different approach
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Preet Pati <preet@preet-6.local> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.