[Common,PWGLF] Task to study ZDC response and calibration in light ion data taking

[coppedis]

We've added a task and a table to better understand and check the ZDC signals in the pO, OO and Ne-Ne runs.

[github-actions]

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

[vkucera]

@coppedis Your PR is not well formatted, yet you opened it as ready for review which triggered compilation tests which are useless at this point and will have to run again.

[coppedis]

If I am not totally wrong, all the remaining linter issues are related to CMakeLists.txt of Common/TableProducer.
If I am not overlooking something, may I ask @ddobrigk to let me know whether we could merge this PR?

Thanks in advance for your help and understanding.
ch.

[vkucera]

If I am not totally wrong, all the remaining linter issues are related to CMakeLists.txt of Common/TableProducer. If I am not overlooking something, may I ask @ddobrigk to let me know whether we could merge this PR?

Thanks in advance for your help and understanding. ch.

Hi @coppedis , the linter also complains about wrong \file documentation field for the zdcTaskLightIons.cxx file, which is part of your changes. Please fix it.

[ddobrigk]

Hi @coppedis , I think the change to the CMakeLists.txt of the PWGMM directory is accidental, right? Could you please remove that change from the PR? I will then approve. Thank you!

[coppedis]

Hi @coppedis , I think the change to the CMakeLists.txt of the PWGMM directory is accidental, right? Could you please remove that change from the PR? I will then approve. Thank you!

Dear @ddobrigk this was a fix (newline at the end of the file) that I erroneously put in and Vit kindly asked me to remove. What do you want me to do? Leave it as approved by Vit or revert to some even previous version? Please, let me know.
Thanks a lot for your help

[ddobrigk]

Hi @coppedis, I think the proper course of action is to leave that CMakeLists file totally unchanged, since you added a task only to Common - it looks confusing that this PR tags PWGLF when in fact you (from what I understand?) only fix one linter issue or so there and it is totally unrelated to the actual work in this PR. To proceed, can you please just take the CMakeLists as it is in the O2Physics master and use that in this PR? If really needed, we can adjust newlines there with a separate PR. Thank you!

[vkucera]

Hi @coppedis , it seems that you overwrote the history of your branch and force-pushed to the remote repository, which is explicitly discouraged in the contribution guidelines. Now your PR makes some unrelated changes in an unrelated file PWGLF/TableProducer/CMakeLists.txt. Please avoid destructive edits of your PR and check your commits before you push them to a PR under review.