Skip to content

[ALICE3] Update LUT configurations to default empty values for nuclei #13400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 11 commits into from
Oct 16, 2025
Merged

[ALICE3] Update LUT configurations to default empty values for nuclei #13400

njacazio merged 11 commits into from
Oct 16, 2025

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Oct 15, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

O2 linter results: ❌ 18 errors, ⚠️ 24 warnings, 🔕 0 disabled

@njacazio njacazio changed the title Update LUT configurations to allow empty values Update LUT configurations to default empty values for nuclei Oct 15, 2025
@github-actions github-actions bot changed the title Update LUT configurations to default empty values for nuclei [ALICE3] Update LUT configurations to allow empty values Oct 15, 2025
@njacazio njacazio marked this pull request as ready for review October 15, 2025 13:12
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 13:12
alibuild
alibuild previously approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio disabled auto-merge October 15, 2025 13:39
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 13:39
alibuild
alibuild previously approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio
Copy link
Collaborator Author

njacazio commented Oct 15, 2025

@jesgum

@njacazio njacazio changed the title [ALICE3] Update LUT configurations to allow empty values [ALICE3] Update LUT configurations to default empty values for nuclei Oct 15, 2025
@njacazio njacazio disabled auto-merge October 15, 2025 13:41
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 13:41
alibuild
alibuild previously approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@jesgum
Copy link
Contributor

jesgum commented Oct 15, 2025 •
edited
Loading

Many thanks @njacazio! Some of these changes i've included in #13325

Specifically for the nuclei, where instead the loading of the luts is behind the existing treat nuclei flag

That pr also introduces the option to use the fassttracker instead if LUTs for primaries which is a feature that I think we want. Should I reopen the pr with only the fasttracker changes or how do we want to proceed?

@njacazio njacazio disabled auto-merge October 15, 2025 14:03
@njacazio njacazio enabled auto-merge (squash) October 15, 2025 14:04
alibuild
alibuild approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @njacazio.

@njacazio njacazio merged commit 7b8296a into master Oct 16, 2025
13 of 15 checks passed
@njacazio njacazio deleted the njacazio-patch-5 branch October 16, 2025 18:42
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@njacazio @ThePhDane
[ALICE3] Update LUT configurations to default empty values for nuclei (…
16e573f 
…AliceO2Group#13400)
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@njacazio
[ALICE3] Update LUT configurations to default empty values for nuclei (…
997336a 
…AliceO2Group#13400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner

Assignees

No one assigned

Labels

alice3

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@njacazio @jesgum @alibuild