[PWGJE] trackEfficiency: add custom track selection for systematics study #13396
Conversation
aimeric-landou
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 0 errors, |
fjonasALICE
left a comment
fjonasALICE
left a comment
There was a problem hiding this comment.
Thanks for the PR, my comments are mainly minor. One general comment: Please consider if you want to filter the collisions or not. Multiple parts of the code mention possible collision filtering. Waiting for @nzardosh for his opinion
PWGJE/Tasks/trackEfficiency.cxx
Outdated
| Configurable<float> effSystMaxChi2PerClusterITS{"effSystMaxChi2PerClusterITS", 36.0, "max chi2 per cluster ITS"}; | ||
| // Configurable<float> effSystMaxDcaXY{"effSystMaxDcaXY", 0.0105 * 0.035 / pT^1.1 ????, "max DCA to vertex xy"}; not including this for now as it's a function with 3 parameters | ||
| Configurable<float> effSystMaxDcaZ{"effSystMaxDcaZ", 2.0, "max DCA to vertex z"}; | ||
| Configurable<float> effSystMinNrequiredHits{"effSystMinNrequiredHits", 1, "minimum number of hits among the 3 innermost layers of the ITS"}; |
There was a problem hiding this comment.
shouldn't this be int instead of float?
There was a problem hiding this comment.
thanks, indeed int would be better
PWGJE/Tasks/trackEfficiency.cxx
Outdated
| PROCESS_SWITCH(TrackEfficiency, processMcCollisionsWeighted, "QA for McCollisions in weighted MC", false); | ||
|
|
||
| void processTrackSelectionHistograms(soa::Join<aod::Tracks, aod::TracksExtra, o2::aod::TracksDCA>::iterator const& track) | ||
| { // should probably select collisions |
There was a problem hiding this comment.
"should probably select collisions". Can you clarify if you still want to do that?
There was a problem hiding this comment.
that is a good point; I wasn't certain of what I wanted when I started writing this;
I will add collision selection as we are I think more interested in the track distributions for those variables only in the collisions we actually keep for the analysis.
|
Thank you @fjonasALICE for your comments, I cleaned up the comments about event selection (i added it a long time ago but forgot to remove the comments then). I need to try the build locally, there are a lot of new commits since I first made this PR so it will take a while, I will push the changes here once I have checked it builds without issue |
aimeric-landou
force-pushed
the
trackEfficiencyVariationSystematics
branch
from
fd4ef50 to
df9a1dc
Compare
|
I had to update O2Physics (git pull --rebase) locally to be able to build (had updated alidist since I initially opened this PR), so I had to force push to my github branch; commits are all the same as before except for the latest one which addresses @fjonasALICE comments |
…tudy (AliceO2Group#13396) Co-authored-by: Aimeric Landou <alandou@Aimerics-MacBook-Pro.local>
3 participants
plus some bug fix for deltapt histograms, and replaced logf to logp