[PWGCF] FemtoUniverse: Fix some O2 linter errors #13388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prchakra
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 82 errors, |
github-actions
bot
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 92dafb8 at 2025-10-14 22:48: Full log here. |
vkucera
reviewed
Oct 16, 2025
Comment on lines
+812
to
+819
| int pairType = 0; | ||
| if (cfgProcessPM) { | ||
| pairType = 1; | ||
| } else if (cfgProcessPP) { | ||
| pairType = 2; | ||
| } else if (cfgProcessMM) { | ||
| pairType = 3; | ||
| } |
Collaborator
There was a problem hiding this comment.
This is just an obfuscation of magic numbers. Use enum for properly named values.
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.