Skip to content

[PWGJE] Adding dphi track check for efficiency calculation #13381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dajones2 wants to merge 6 commits into from
Closed

[PWGJE] Adding dphi track check for efficiency calculation #13381

dajones2 wants to merge 6 commits into from

Conversation

@dajones2
Copy link
Contributor

@dajones2 dajones2 commented Oct 14, 2025

No description provided.

@github-actions github-actions bot added the pwgje label Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

O2 linter results: ❌ 21 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title PWGJE: Adding dphi track check for efficiency calculation [PWGJE] Adding dphi track check for efficiency calculation Oct 14, 2025
@alibuild alibuild mentioned this pull request Oct 14, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Oct 14, 2025

Error while checking build/O2Physics/o2 for cda01eb at 2025-10-14 12:30:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:968:27: error: expected identifier before ')' token
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:402:37: error: 'collision' was not declared in this scope; did you mean 'o2::aod::collision'?
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:934:22: error: no matching function for call to 'JetHadronRecoil::fillHistogramsMCD(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3517389944>, o2::aod::Hash<2646580906>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3537415913>, o2::aod::Hash<1322391187>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<4011097074>, o2::aod::Hash<4019947998>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3976921519>, o2::aod::Hash<602361033>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::Table<o2::aod::Hash<773905682>, o2::aod::Hash<2113276350>, o2::aod::Hash<2286545062> > >&, double, double, const float&)'
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:960:22: error: no matching function for call to 'JetHadronRecoil::fillHistogramsMCD(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3517389944>, o2::aod::Hash<2646580906>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3537415913>, o2::aod::Hash<1322391187>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<4011097074>, o2::aod::Hash<4019947998>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3976921519>, o2::aod::Hash<602361033>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::Table<o2::aod::Hash<773905682>, o2::aod::Hash<2113276350>, o2::aod::Hash<2286545062> > >&, double, const float&, const float&)'
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:1012:22: error: no matching function for call to 'JetHadronRecoil::fillHistogramsMCD(const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3517389944>, o2::aod::Hash<2646580906>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3537415913>, o2::aod::Hash<1322391187>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<4011097074>, o2::aod::Hash<4019947998>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3976921519>, o2::aod::Hash<602361033>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::Table<o2::aod::Hash<773905682>, o2::aod::Hash<2113276350>, o2::aod::Hash<2286545062> > >&, const float&, const float&, const float&)'
/sw/slc9_x86-64/O2/daily-20251014-0000-local1/include/Framework/AnalysisTask.h:156:49: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::inputsFromArgs(void (JetHadronRecoil::*&)(const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<3489904409>, o2::aod::Hash<3504405650>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<3489904409>, o2::aod::Hash<3504405650>, o2::aod::Hash<2286545062> > > >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<3489904409>, o2::aod::Hash<3504405650>, o2::aod::Hash<2286545062> > >&, const o2::soa::Table<o2::aod::Hash<1946615853>, o2::aod::Hash<440030369>, o2::aod::Hash<2286545062> >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3517389944>, o2::aod::Hash<2646580906>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3537415913>, o2::aod::Hash<1322391187>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<4011097074>, o2::aod::Hash<4019947998>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2539817241>, o2::aod::Hash<1786619950>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3976921519>, o2::aod::Hash<602361033>, o2::aod::Hash<2286545062> > > >&, int), const char*, bool&, std::vector<o2::framework::InputSpec>&, std::vector<ExpressionInfo>&)'
/sw/slc9_x86-64/O2/daily-20251014-0000-local1/include/Framework/AnalysisTask.h:167:48: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::cacheFromArgs(void (JetHadronRecoil::*&)(const o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<3489904409>, o2::aod::Hash<3504405650>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::FilteredIndexPolicy, o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<3489904409>, o2::aod::Hash<3504405650>, o2::aod::Hash<2286545062> > > >, o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3292202882>, o2::aod::Hash<1154616615>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2114154707>, o2::aod::Hash<3650294195>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<3489904409>, o2::aod::Hash<3504405650>, o2::aod::Hash<2286545062> > >&, const o2::soa::Table<o2::aod::Hash<1946615853>, o2::aod::Hash<440030369>, o2::aod::Hash<2286545062> >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<3517389944>, o2::aod::Hash<2646580906>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3537415913>, o2::aod::Hash<1322391187>, o2::aod::Hash<2286545062> > > >&, const o2::soa::Filtered<o2::soa::JoinFull<o2::aod::Hash<1837103245>, o2::soa::Table<o2::aod::Hash<4011097074>, o2::aod::Hash<4019947998>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<2539817241>, o2::aod::Hash<1786619950>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<3976921519>, o2::aod::Hash<602361033>, o2::aod::Hash<2286545062> > > >&, int), bool&, o2::framework::Cache&, o2::framework::Cache&)'
/sw/slc9_x86-64/O2/daily-20251014-0000-local1/include/Framework/AnalysisTask.h:299:83: error: no matching function for call to 'o2::framework::{anonymous}::AnalysisDataProcessorBuilder::extract<std::decay_t<int>, 4>(o2::framework::InputRecord&, std::vector<ExpressionInfo>&, const unsigned int&)'
ninja: build stopped: subcommand failed.

Full log here.

nzardosh
nzardosh previously approved these changes Oct 14, 2025
View reviewed changes
@nzardosh nzardosh self-requested a review October 14, 2025 11:20
@alibuild
Copy link
Collaborator

alibuild commented Oct 15, 2025

Error while checking build/O2Physics/o2 for 2cb7a45 at 2025-10-15 08:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:352:121: error: default argument missing for parameter 6 of 'void JetHadronRecoil::fillHistogramsMCD(const T&, const U&, float, float, float, auto:171)'
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:406:43: error: 'collision' was not declared in this scope; did you mean 'o2::aod::collision'?
/sw/SOURCES/O2Physics/13381-slc9_x86-64/0/PWGJE/Tasks/jetHadronRecoil.cxx:352:121: error: unused parameter 'collisionID' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@dajones2 dajones2 closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@maoyx maoyx Awaiting requested review from maoyx maoyx is a code owner

@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner

@mfasDa mfasDa Awaiting requested review from mfasDa mfasDa is a code owner

@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner

Assignees

No one assigned

Labels

pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dajones2 @alibuild @nzardosh