[PWGCF] Suggested improvements for resonance implementation #13361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inside ResoSelectionsome uint_32 return types were replaced by integer types. A suggested usecase for std::hypot was implemented. A check for iteratortype inside femtoDreamContainer.h was improved.
gitchrishub-oss
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 4 errors, |
ariedel-cern
approved these changes
Oct 13, 2025
Collaborator
|
I recommend fixing the errors and warnings. |
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…roup#13361) Co-authored-by: Christopher Klumm <ge48xun@nidoking.ktas.ph.tum.de>
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
…roup#13361) Co-authored-by: Christopher Klumm <ge48xun@nidoking.ktas.ph.tum.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inside ResoSelection some uint_32 return types were replaced by integer types. A suggested use case for std::hypot was implemented. A check for iterator type inside femtoDreamContainer.h was improved.
@AntonRiedel
@gmantzar