-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGHF] candidateSelectorOmegac0Xic0ToOmegaKa.cxx: Fix configuration key name mismatch and O2linter errors. #13353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix a name bug.
|
O2 linter results: ❌ 0 errors, |
[PWGHF] Please consider the following formatting changes to AliceO2Group#13353
vkucera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FDUEnrich The changes don't seem to me like a name fix. Can you please give more details in the description?
Fix the errors and warnings.
@zhangbiao-phy please don't approve PRs which have errors or warnings.
Hi, Vit. Actually it is a configuration key name mismatch error. The key change is : -if (kaPtFromOmegaKa < cuts->get(pTBin, "pT ka from OmegaKa")) { |
|
Error while checking build/O2Physics/o2 for 8894f1b at 2025-10-12 19:46: Full log here. |
Hi @vkucera, that's why I didn't merge it and asked Ruiqi to fix it privately |
Ah ok, thanks. I didn't know. |
Hi, Vit. I've modified as your requested. Could you please approve my PR? |
Head branch was pushed to by a user without write access
vkucera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FDUEnrich Thanks for fixing the errors and warnings.
…key name mismatch and O2linter errors. (AliceO2Group#13353) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
…key name mismatch and O2linter errors. (AliceO2Group#13353) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Fix a name bug.