Skip to content

Conversation

@FDUEnrich
Copy link
Contributor

Fix a name bug.

@github-actions
Copy link

github-actions bot commented Oct 12, 2025

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix a name error. [PWGHF] Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix a name error. Oct 12, 2025
[PWGHF] Please consider the following formatting changes to AliceO2Group#13353
zhangbiao-phy
zhangbiao-phy previously approved these changes Oct 12, 2025
@zhangbiao-phy zhangbiao-phy changed the title [PWGHF] Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix a name error. [PWGHF] Fix a name error in candidateSelectorOmegac0Xic0ToOmegaKa.cxx Oct 12, 2025
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FDUEnrich The changes don't seem to me like a name fix. Can you please give more details in the description?
Fix the errors and warnings.
@zhangbiao-phy please don't approve PRs which have errors or warnings.

@FDUEnrich FDUEnrich requested a review from vkucera October 12, 2025 17:18
@FDUEnrich FDUEnrich changed the title [PWGHF] Fix a name error in candidateSelectorOmegac0Xic0ToOmegaKa.cxx [PWGHF] Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix name and O2linter errors. Oct 12, 2025
@FDUEnrich FDUEnrich changed the title [PWGHF] Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix name and O2linter errors. [PWGHF] Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix configuration key name mismatch and O2linter errors. Oct 12, 2025
@FDUEnrich
Copy link
Contributor Author

@FDUEnrich The changes don't seem to me like a name fix. Can you please give more details in the description? Fix the errors and warnings. @zhangbiao-phy please don't approve PRs which have errors or warnings.

Hi, Vit. Actually it is a configuration key name mismatch error. The key change is : -if (kaPtFromOmegaKa < cuts->get(pTBin, "pT ka from OmegaKa")) {
+if (kaPtFromOmegaKa < cuts->get(pTBin, "pT Ka from Omegac")) {

@alibuild
Copy link
Collaborator

Error while checking build/O2Physics/o2 for 8894f1b at 2025-10-12 19:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13353-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorOmegac0Xic0ToOmegaKa.cxx:716:23: error: 'HfCandidateSelectorToOmegaKa' was not declared in this scope; did you mean 'HfCandidateSelectorOmegac0Xic0ToOmegaKa'?
/sw/SOURCES/O2Physics/13353-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorOmegac0Xic0ToOmegaKa.cxx:716:52: error: no matching function for call to 'adaptAnalysisTask<<expression error> >(const o2::framework::ConfigContext&)'
/sw/SOURCES/O2Physics/13353-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorOmegac0Xic0ToOmegaKa.cxx:716:52: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/13353-slc9_x86-64/0/PWGHF/TableProducer/candidateSelectorOmegac0Xic0ToOmegaKa.cxx:716:58: error: no matching function for call to 'std::vector<o2::framework::DataProcessorSpec>::vector(<brace-enclosed initializer list>)'
ninja: build stopped: subcommand failed.

Full log here.

@zhangbiao-phy
Copy link
Collaborator

@FDUEnrich The changes don't seem to me like a name fix. Can you please give more details in the description? Fix the errors and warnings. @zhangbiao-phy please don't approve PRs which have errors or warnings.

Hi @vkucera, that's why I didn't merge it and asked Ruiqi to fix it privately

@vkucera
Copy link
Collaborator

vkucera commented Oct 13, 2025

@FDUEnrich The changes don't seem to me like a name fix. Can you please give more details in the description? Fix the errors and warnings. @zhangbiao-phy please don't approve PRs which have errors or warnings.

Hi @vkucera, that's why I didn't merge it and asked Ruiqi to fix it privately

Ah ok, thanks. I didn't know.

@zhangbiao-phy zhangbiao-phy enabled auto-merge (squash) October 13, 2025 12:11
@FDUEnrich
Copy link
Contributor Author

@FDUEnrich The changes don't seem to me like a name fix. Can you please give more details in the description? Fix the errors and warnings. @zhangbiao-phy please don't approve PRs which have errors or warnings.

Hi @vkucera, that's why I didn't merge it and asked Ruiqi to fix it privately

Ah ok, thanks. I didn't know.

Hi, Vit. I've modified as your requested. Could you please approve my PR?

@vkucera vkucera changed the title [PWGHF] Update candidateSelectorOmegac0Xic0ToOmegaKa.cxx. Fix configuration key name mismatch and O2linter errors. [PWGHF] candidateSelectorOmegac0Xic0ToOmegaKa.cxx: Fix configuration key name mismatch and O2linter errors. Oct 14, 2025
auto-merge was automatically disabled October 14, 2025 11:00

Head branch was pushed to by a user without write access

Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FDUEnrich Thanks for fixing the errors and warnings.

@zhangbiao-phy zhangbiao-phy merged commit 1923ab4 into AliceO2Group:master Oct 15, 2025
12 of 13 checks passed
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
…key name mismatch and O2linter errors. (AliceO2Group#13353)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
…key name mismatch and O2linter errors. (AliceO2Group#13353)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants