[PWGHF] Use auto for values returned from functions #13330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rrantu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
github-actions
bot
changed the title
lubynets
reviewed
Oct 10, 2025
PWGHF/D2H/Tasks/taskLc.cxx
Outdated
| for (const auto& collision : collisions) { | ||
|
|
||
| uint32_t rejectionMask{0}; // 32 bits, in case new ev. selections will be added | ||
| auto rejectionMask{0}; // 32 bits, in case new ev. selections will be added |
Contributor
There was a problem hiding this comment.
Please combine this line with r.h.s. function output - then auto will be deduced properly. Now it is int.
Contributor
There was a problem hiding this comment.
And since it is not supposed to be changed (?) consider making it const.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! I’ve updated the code accordingly.
zhangbiao-phy
approved these changes
Oct 10, 2025
lubynets
added a commit
to lubynets/O2Physics
that referenced
this pull request
Oct 10, 2025
add const and const& add author
Collaborator
|
@Rrantu Thanks for the fix. In your future PRs, please add in the title which file or analysis is modified by the PR. |
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed hard-coded types for function return values and Added process function without ML with UPC