[PWGHF] Add UPC process function and QA hists #13328
Conversation
Rrantu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 1 errors, |
|
Hi @Rrantu, many thanks for the implementation! I see there is linter error but not related to your PR. So all looks good! |
| } | ||
| } | ||
|
|
||
| template <bool fillMl, typename CollType, typename CandType, typename BCsType> |
There was a problem hiding this comment.
If you call this function only once, with fillMl = true, why do you need this parameter? Or do you foresee in future cases when this function should be called with false?
There was a problem hiding this comment.
Hi @lubynets, indeed, maybe we can consider adding one process function without ML in the future
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
Please address my comments.
| GapType determineGapType(float FT0A, float FT0C, float ZNA, float ZNC) | ||
| { | ||
| constexpr float FT0AThreshold = 100.0; | ||
| constexpr float FT0CThreshold = 50.0; | ||
| constexpr float ZDCThreshold = 1.0; | ||
| if (FT0A < FT0AThreshold && FT0C > FT0CThreshold && ZNA < ZDCThreshold && ZNC > ZDCThreshold) { | ||
| return GapType::GapA; | ||
| } | ||
| if (FT0A > FT0AThreshold && FT0C < FT0CThreshold && ZNA > ZDCThreshold && ZNC < ZDCThreshold) { | ||
| return GapType::GapC; | ||
| } | ||
| return GapType::DoubleGap; | ||
| } |
There was a problem hiding this comment.
Isn't this supposed to be done by the SG selector?
There was a problem hiding this comment.
Hi @vkucera, yes, similar logic in the trueGap:
O2Physics/PWGUD/Core/SGSelector.h
Line 141 in 41d60bb
But we can't use the UD collision table. So we define the function in our HF task now
| uint32_t rejectionMask{0}; // 32 bits, in case new ev. selections will be added | ||
| float centrality{-1.f}; | ||
| rejectionMask = hfEvSel.getHfCollisionRejectionMaskWithUpc<true, CentralityEstimator::None, BCsType>(collision, centrality, ccdb, qaRegistry, bcs); |
There was a problem hiding this comment.
Do not hard-code the types of values that you receive from functions. I removed these cases from HF some time ago. Where did you take this piece from?
There was a problem hiding this comment.
Sorry, I missed that point. I’ll update the code accordingly and submit a new PR.
add const and const& add author
4 participants
Implemented a new function to process UPC events and added corresponding QA histograms.