[PWGJE] added corrected cluster energy tables in my task #13324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archita-Dash
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 37 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#13324
nzardosh
approved these changes
Oct 10, 2025
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
…p#13324) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
…p#13324) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
…p#13324) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi Nima,
In this PR, I have now updated the cluster energy tables in my task with the 4 variations of corrected cluster energies such that the task runs seamlessly for any choice of correction mode. I have now joined the raw cluster energy table with the corrected ones and thereby I have updated the calculations of NEF for each instance of the cluster correction for QA.
I have tested this with both data and MC locally and this works as desired with different correction modes.
I would appreciate if this PR gets approved sooner so that I can rerun my systematics.
Cheers,
Archita