[PWGCF] Set global tracks in track filter #13317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilikmeta
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#13317
| ifnode(dcaZ > 0.f, nabs(aod::track::dcaZ) <= dcaZ && ncheckbit(aod::track::trackCutFlag, TrackSelectionDCAXYonly), | ||
| ncheckbit(aod::track::trackCutFlag, TrackSelectionDCA)) && | ||
| (nabs(aod::track::eta) < cfgCutEta) && (aod::track::pt > cfgCutPtMin) && (aod::track::pt < cfgCutPtMax) && (aod::track::tpcChi2NCl < cfgCutChi2prTPCcls); | ||
| Filter trackFilter = (nabs(aod::track::eta) < cfgCutEta) && (aod::track::pt > cfgCutPtMin) && (aod::track::pt < cfgCutPtMax) && ((requireGlobalTrackInFilter()) || (aod::track::isGlobalTrackSDD == (uint8_t) true)) && (aod::track::tpcChi2NCl < cfgCutChi2prTPCcls) && (nabs(aod::track::dcaZ) < cfgCutDCAz); |
Collaborator
There was a problem hiding this comment.
Be aware that if your cuts are less demanding than the GlobalTrack criteria they will not have effect
Contributor
Author
There was a problem hiding this comment.
Thank you for your comment Victor! At this point I wanted to compare the global track trackFilter with the one I had before for global+ITS tracks. I see your point and makes sense. I will investigate it
victor-gonzalez
approved these changes
Oct 9, 2025
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back to Global track filter (from the Global+ITS sample). Also, rearranging few lines.