[PWGCF] Mean pT fluctuations in PbPb 5.36TeV #13263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please, rebase your local repo to the latest version of O2Physics and update your fork in gitHub with it |
sweta29singh
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Please, rebase your changes to the latest version of the central repo |
Collaborator
|
Error while checking build/O2Physics/o2 for 83acce8 at 2025-10-08 11:24: Full log here. |
Comment on lines
+65
to
+126
| Configurable<float> cVtxZcut{"cVtxZcut", 10.0f, "Vertex Z"}; | ||
| Configurable<float> cEtacut{"cEtacut", 0.8f, "Eta cut"}; | ||
| Configurable<float> cPtmincut{"cPtmincut", 0.15f, "Pt min cut"}; | ||
| Configurable<float> cPtmaxcut{"cPtmaxcut", 2.0f, "Pt max cut"}; | ||
| Configurable<float> cPtmincut1{"cPtmincut1", 0.15f, " Pt min cut"}; | ||
| Configurable<float> cPtmaxcut1{"cPtmaxcut1", 2.0f, " Pt max cut"}; | ||
| Configurable<float> cDcaXYcut{"cDcaXYcut", 0.3f, "DCA XY cut"}; | ||
| Configurable<float> cDcaZcut{"cDcaZcut", 2.0f, "DCA Z cut"}; | ||
| Configurable<float> cCentmincut{"cCentmincut", 0.0, "Min cent cut"}; | ||
| Configurable<float> cCentmaxcut{"cCentmaxcut", 90.0, "Max cent cut"}; | ||
| Configurable<int> cTPCcrosscut{"cTPCcrosscut", 70, "TPC crossrows cut"}; | ||
| Configurable<int> cItsChiCut{"cItsChiCut", 36, "ITS chi2 cluster cut"}; | ||
| Configurable<int> cTpcChiCut{"cTpcChiCut", 4, "TPC chi2 cluster cut"}; | ||
| Configurable<int> cnITSClustersCut{"cnITSClustersCut", 5, "Number of ITS clusters cut"}; | ||
| Configurable<int> ctpcNClsCut{"ctpcNClsCut", 80, "No. of TPC clusters cut"}; | ||
| Configurable<double> threshold{"threshold", 1e-6, "Delta eta bin count"}; | ||
| Configurable<float> ptMax{"ptMax", 2.0, "maximum pT"}; | ||
| Configurable<float> ptMin{"ptMin", 0.15, "minimum pT"}; | ||
| Configurable<std::vector<double>> ptBins{"ptBins", {0.15, 0.20, 0.25, 0.30, 0.35, 0.40, 0.45, 0.50, 0.55, 0.60, 0.65, 0.70, 0.75, 0.80, 0.85, 0.90, 0.95, 1.00, 1.05, 1.10, 1.15, 1.20, 1.25, 1.30, 1.35, 1.40, 1.45, 1.50, 1.55, 1.60, 1.65, 1.70, 1.75, 1.80, 1.85, 1.90, 1.95, 2.00}, "p_{T} bins"}; | ||
| Configurable<float> piluprejection{"piluprejection", false, "Pileup rejection"}; | ||
|
|
||
| // Event selections | ||
| Configurable<bool> cSel8Trig{"cSel8Trig", true, "Sel8 (T0A + T0C) Selection Run3"}; | ||
| Configurable<bool> cTFBorder{"cTFBorder", true, "Timeframe Border Selection"}; | ||
| Configurable<bool> cNoItsROBorder{"cNoItsROBorder", true, "No ITSRO Border Cut"}; | ||
| Configurable<bool> cItsTpcVtx{"cItsTpcVtx", true, "ITS+TPC Vertex Selection"}; | ||
| Configurable<bool> cPileupReject{"cPileupReject", true, "Pileup rejection"}; | ||
| Configurable<bool> cZVtxTimeDiff{"cZVtxTimeDiff", true, "z-vtx time diff selection"}; | ||
| Configurable<bool> cIsGoodITSLayers{"cIsGoodITSLayers", true, "Good ITS Layers All"}; | ||
| Configurable<bool> cItslayerall{"cItslayerall", true, "dead staves of ITS removed"}; | ||
| Configurable<bool> cvtxtofmatched{"cvtxtofmatched", true, "TOF vertex matched"}; | ||
| Configurable<bool> cfgRejEl{"cfgRejEl", false, "Rejected electrons"}; | ||
| Configurable<bool> cdata{"cdata", false, "Enable histogram filling for processData"}; | ||
| Configurable<bool> citsNCluster{"citsNCluster", false, "Enable Number of ITS clusters"}; | ||
| Configurable<bool> ctpcNClusterFound{"ctpcNClusterFound", false, "Enable Number of TPC clusters"}; | ||
| Configurable<bool> cPVContributor{"cPVContributor", false, "Enable Primary Vertex Contributor"}; | ||
| Configurable<bool> cDCAxy{"cDCAxy", true, "DCAxy cut"}; | ||
| Configurable<bool> cDCAz{"cDCAz", true, "DCAz cut"}; | ||
| Configurable<bool> cTPCcr{"cTPCcr", true, "tpc crossed rows"}; | ||
| Configurable<bool> cITSchi{"cITSchi", true, "ITS chi2"}; | ||
| Configurable<bool> cTPCchi{"cTPCchi", true, "TPC chi2"}; | ||
| Configurable<bool> ccentFT0C{"ccentFT0C", true, "Use FT0C centraity"}; | ||
|
|
||
| // PID selection configurables | ||
| Configurable<float> cPionPmincut{"cPionPmincut", 0.15, "pion min cut of pion"}; | ||
| Configurable<float> cKaonPmincut{"cKaonPmincut", 0.15, "kaon min cut of kaon"}; | ||
| Configurable<float> cProtonPmincut{"cProtonPmincut", 0.15, "proton min cut of proton"}; | ||
| Configurable<float> cPionPmaxcut{"cPionPmaxcut", 2.0, "pion min cut of pion"}; | ||
| Configurable<float> cKaonPmaxcut{"cKaonPmaxcut", 2.0, "kaon min cut of kaon"}; | ||
| Configurable<float> cProtonPmaxcut{"cProtonPmaxcut", 2.0, "proton min cut of proton"}; | ||
| Configurable<float> cPionPthcut{"cPionPthcut", 0.65, "pion threshold cut of pion"}; | ||
| Configurable<float> cKaonPthcut{"cKaonPthcut", 0.65, "kaon threshold cut of kaon"}; | ||
| Configurable<float> cProtonPthcut{"cProtonPthcut", 1.0, "proton threshold cut of proton"}; | ||
| Configurable<float> cNSigCut2{"cNSigCut2", 2.0, "nSigma cut (2)"}; | ||
| Configurable<float> cNSigCut3{"cNSigCut3", 3.0, "nSigma cut (3)"}; | ||
| Configurable<float> cElMinCut{"cElMinCut", -3.0, "electron min cut"}; | ||
| Configurable<float> cElMaxCut{"cElMaxCut", 5.0, "electron max cut"}; | ||
| Configurable<float> cTwoPtlCut2{"cTwoPtlCut2", 2.0, "n2ptl cut"}; | ||
| Configurable<float> cRapidityCut05{"cRapidityCut05", 0.5, "rapidity cut"}; | ||
| Configurable<int> nchBins{"nchBins", 4000, "Number of bins for nch axis"}; | ||
| Configurable<float> nchMin{"nchMin", 0.0, "Minimum value for nch axis"}; | ||
| Configurable<float> nchMax{"nchMax", 4000.0, "Maximum value for nch axis"}; |
Collaborator
There was a problem hiding this comment.
I would suggest to also group these configurables
If not at some point the limit in the number of objects owned by the task will be reached
Also I would suggest to use a prefix so that they are available in an ordered way in hyperloop
Comment on lines
+147
to
+156
| std::vector<double> multPVFT0CCutPars; | ||
| std::vector<double> multGlobalFT0CPars; | ||
| std::vector<double> multGlobalPVCutPars; | ||
|
|
||
| TF1* fMultPVFT0CCutLow = nullptr; | ||
| TF1* fMultPVFT0CCutHigh = nullptr; | ||
| TF1* fMultGlobalFT0CCutLow = nullptr; | ||
| TF1* fMultGlobalFT0CCutHigh = nullptr; | ||
| TF1* fMultGlobalPVCutLow = nullptr; | ||
| TF1* fMultGlobalPVCutHigh = nullptr; |
Collaborator
There was a problem hiding this comment.
Have you check that this works locally?
Are you sure it will work on hyperloop?
I am asking because I am not quite sure if including other objects than configurables is expected in a ConfigurableGroup
Again, a prefix will easy its visualization in hyperloop
Comment on lines
+166
to
+186
| using MyCollisions = soa::Filtered<soa::Join<aod::Collisions, aod::EvSels, aod::Mults, aod::CentFT0Cs, aod::CentFT0Ms, aod::CentFT0As, aod::CentFV0As>>; | ||
| using MyCollision = MyCollisions::iterator; | ||
|
|
||
| using MyTracks = soa::Filtered<soa::Join<aod::FullTracks, | ||
| aod::pidTPCFullEl, aod::pidTPCFullMu, aod::pidTPCFullPi, | ||
| aod::pidTPCFullKa, aod::pidTPCFullPr, aod::pidTPCFullDe, | ||
| aod::pidTOFFullEl, aod::pidTOFFullMu, aod::pidTOFFullPi, aod::StoredTracks, | ||
| aod::pidTOFFullKa, aod::pidTOFFullPr, aod::pidTOFFullDe, aod::pidTOFbeta, aod::TOFSignal, aod::TracksExtra, aod::TracksIU, aod::TracksDCA, aod::TrackSelection>>; | ||
| using MyTrack = MyTracks::iterator; | ||
|
|
||
| using MyMCRecoCollisions = soa::Filtered<soa::Join<aod::Collisions, aod::EvSels, aod::Mults, aod::CentFT0Cs, aod::McCollisionLabels, aod::CentFT0Ms, aod::CentFT0As, aod::CentFV0As>>; | ||
| using MyMCRecoCollision = MyMCRecoCollisions::iterator; | ||
|
|
||
| using MyMCRecoTracks = soa::Filtered<soa::Join<aod::FullTracks, | ||
| aod::pidTPCFullEl, aod::pidTPCFullMu, aod::pidTPCFullPi, | ||
| aod::pidTPCFullKa, aod::pidTPCFullPr, aod::pidTPCFullDe, | ||
| aod::pidTOFFullEl, aod::pidTOFFullMu, aod::pidTOFFullPi, aod::StoredTracks, | ||
| aod::pidTOFFullKa, aod::pidTOFFullPr, aod::pidTOFFullDe, aod::pidTOFbeta, aod::TOFSignal, aod::TracksExtra, aod::TracksIU, aod::TracksDCA, aod::TrackSelection, aod::McTrackLabels>>; | ||
| using MyMCRecoTrack = MyMCRecoTracks::iterator; | ||
|
|
||
| using EventCandidatesMC = soa::Join<aod::Collisions, aod::EvSels, aod::McCollisionLabels, aod::CentFT0Cs, aod::CentFT0Ms, aod::Mults>; |
Collaborator
There was a problem hiding this comment.
I would suggest keeping the Filter name in the using name because they are filtered and at some point it will be forgotten
| AxisSpec dcaAxis = {1002, -5.01, 5.01, "DCA_{xy} (cm)"}; | ||
| AxisSpec dcazAxis = {1002, -5.01, 5.01, "DCA_{z} (cm)"}; | ||
| AxisSpec ptAxis = {600, 0.0, 6.0, "#it{p}_{T} (GeV/#it{c})"}; | ||
| AxisSpec ptAxis = {600, 0.0, 6.0, "#it{p}_{T} (GeV/#it{c})"}; // 600,0,6 |
Collaborator
There was a problem hiding this comment.
Why the comment? Is it not self evident? If it is kept probably will be needed to be updated in case of a change which is cumbersome
| cfgFunCoeff.multGlobalFT0CPars = cfgFunCoeff.cfgMultGlobalFT0CCutPars; | ||
| cfgFunCoeff.multGlobalPVCutPars = cfgFunCoeff.cfgMultGlobalPVCutPars; | ||
|
|
||
| Configurable<float> cSigmaLowHighcut{"cSigmaLowHighcut", 3.0f, "lower and upper sigma cut"}; |
victor-gonzalez
approved these changes
Oct 8, 2025
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
I approve it for the time being but, please, have a look at my comments in case you want to consider them for future iterations
Contributor
Author
Dear @victor-gonzalez |
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some histograms for multiplicity correlation plots