Skip to content

[PWGLF] Add task for pseudo-efficiency checks #13257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gbencedi merged 3 commits into from
Oct 6, 2025
Merged

[PWGLF] Add task for pseudo-efficiency checks #13257

gbencedi merged 3 commits into from
Oct 6, 2025

Conversation

@gbencedi
Copy link
Collaborator

@gbencedi gbencedi commented Oct 6, 2025 •
edited
Loading

Task to check pseudo-efficiency in Pb-Pb collisions, based on https://github.com/mcoquet642/O2Physics/tree/dq-mft-eff

@github-actions github-actions bot added the pwglf label Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Add task for pseudo-efficiency checks [PWGLF] Add task for pseudo-efficiency checks Oct 6, 2025
@alibuild
Copy link
Collaborator

alibuild commented Oct 6, 2025

Error while checking build/O2Physics/o2 for 4253a2c at 2025-10-06 20:41:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13257-slc9_x86-64/0/PWGMM/Mult/Tasks/pseudoEffMFT.cxx:1045:15: error: cannot convert 'const std::vector<int>*' to 'std::vector<int>*'
/sw/SOURCES/O2Physics/13257-slc9_x86-64/0/PWGMM/Mult/Tasks/pseudoEffMFT.cxx:1039:20: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/13257-slc9_x86-64/0/PWGMM/Mult/Tasks/pseudoEffMFT.cxx:1039:20: error: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int64_t' {aka 'long int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@gbencedi gbencedi enabled auto-merge (squash) October 6, 2025 20:32
alibuild
alibuild approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @gbencedi.

@gbencedi gbencedi merged commit bf7205c into AliceO2Group:master Oct 6, 2025
12 of 13 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
@gbencedi @jinhyunni
[PWGLF] Add task for pseudo-efficiency checks (AliceO2Group#13257)
0047c56
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
@gbencedi
[PWGLF] Add task for pseudo-efficiency checks (AliceO2Group#13257)
6fe8dfd
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@gbencedi @ThePhDane
[PWGLF] Add task for pseudo-efficiency checks (AliceO2Group#13257)
533c18a
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@gbencedi @jloemker
[PWGLF] Add task for pseudo-efficiency checks (AliceO2Group#13257)
4fc505b
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@gbencedi
[PWGLF] Add task for pseudo-efficiency checks (AliceO2Group#13257)
266e56f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild alibuild approved these changes

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@aalkin aalkin Awaiting requested review from aalkin aalkin is a code owner

@aortizve aortizve Awaiting requested review from aortizve aortizve is a code owner

@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

@jgcn jgcn Awaiting requested review from jgcn jgcn is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gbencedi @alibuild