[PWGEM/Dilepton] quick fix in eventQC.cxx #13233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsekihat
requested review from
alibuild,
feisenhu,
hscheid,
ivorobye,
mikesas and
rbailhac
as code owners
|
O2 linter results: ❌ 122 errors, |
github-actions
bot
changed the title
Member
|
This is what is (silently) breaking the production of histograms. Changing it to a 16 bit number (silently) clashes with the configuration in hyperloop which is still for an int, and the hyperloop value is ignored. You need to either revert this or fix the issue in hyperloop. I have opened a separate PR which will take care of providing a runtime error when you try to fit in a configurable a number larger than the storage type. |
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Oct 11, 2025
ArkaprabhaSaha001
pushed a commit
to ArkaprabhaSaha001/O2Physics
that referenced
this pull request
Oct 21, 2025
ThePhDane
pushed a commit
to ThePhDane/O2Physics
that referenced
this pull request
Nov 3, 2025
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWGEM/Dilepton: quick fix in eventQC.cxx