Skip to content

[DPG] Adding new HMPID tasks #13225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 16 commits into from
Nov 1, 2025
Merged

[DPG] Adding new HMPID tasks #13225

njacazio merged 16 commits into from
Nov 1, 2025

Conversation

@gvolpe79
Copy link
Contributor

@gvolpe79 gvolpe79 commented Oct 3, 2025

No description provided.

@github-actions github-actions bot added the dpg label Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 21 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Adding new HMPID tasks [DPG] Adding new HMPID tasks Oct 3, 2025
@alibuild alibuild mentioned this pull request Oct 3, 2025
Closed
@alibuild
Copy link
Collaborator

alibuild commented Oct 3, 2025

Error while checking build/O2Physics/o2 for 823cb00 at 2025-10-03 16:33:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pp.cxx:116:12: error: unused variable 'probabilityParticle' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pp.cxx:578:24: error: 'sin2changle' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pb.cxx:113:12: error: unused variable 'probabilityParticle' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pb.cxx:653:24: error: 'sin2changle' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Oct 3, 2025

Error while checking build/O2Physics/o2 for c89d2c7 at 2025-10-03 16:38:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pb.cxx:111:12: error: unused variable 'probabilityParticle' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pb.cxx:606:24: error: 'sin2changle' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pp.cxx:114:12: error: unused variable 'probabilityParticle' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pp.cxx:557:24: error: 'sin2changle' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild alibuild mentioned this pull request Oct 3, 2025
Closed
@vkucera vkucera marked this pull request as draft October 3, 2025 16:16
@vkucera
Copy link
Collaborator

vkucera commented Oct 3, 2025 •
edited
Loading

@gvolpe79 Please do not open PRs as "ready for review" which do not compile and fail other required checks.

@alibuild
Copy link
Collaborator

alibuild commented Oct 4, 2025

Error while checking build/O2Physics/o2 for cc54e3a at 2025-10-04 12:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pb.cxx:111:12: error: unused variable 'probabilityParticle' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pb.cxx:606:24: error: 'sin2changle' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pp.cxx:114:12: error: unused variable 'probabilityParticle' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/13225-slc9_x86-64/0/DPG/Tasks/AOTTrack/PID/HMPID/qaHMPID_pp.cxx:557:24: error: 'sin2changle' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Oct 4, 2025
View reviewed changes
@alibuild alibuild mentioned this pull request Oct 14, 2025
Closed
vkucera
vkucera reviewed Oct 15, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 16, 2025
View reviewed changes
@alibuild alibuild mentioned this pull request Oct 17, 2025
Closed
vkucera
vkucera reviewed Oct 17, 2025
View reviewed changes
vkucera
vkucera reviewed Oct 20, 2025
View reviewed changes
@vkucera
Copy link
Collaborator

vkucera commented Oct 20, 2025

This PR is creating significant code duplication by splitting files in two for pp and PbPb. I don't see how that is justified.

vkucera
vkucera reviewed Oct 21, 2025
View reviewed changes
@vkucera
Copy link
Collaborator

vkucera commented Oct 21, 2025

Thanks for addressing my comments.

@gvolpe79 gvolpe79 marked this pull request as ready for review October 24, 2025 13:33
@njacazio njacazio merged commit 4038605 into AliceO2Group:master Nov 1, 2025
13 checks passed
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@gvolpe79 @ThePhDane
[DPG] Adding new HMPID tasks (AliceO2Group#13225)
2aa88e8
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
@gvolpe79
[DPG] Adding new HMPID tasks (AliceO2Group#13225)
89e0fc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@njacazio njacazio njacazio approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@iouribelikov iouribelikov Awaiting requested review from iouribelikov iouribelikov is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

Assignees

No one assigned

Labels

dpg

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gvolpe79 @alibuild @vkucera @njacazio