Skip to content

Conversation

@GiorgioAlbertoLucia
Copy link
Contributor

  • nucleiQC.cxx is added for QC of nuclei and producing output tables upon request for studies of primary fractions (this will be used for the p-He3 analysis)
  • A small table is added for this reason to LFSlimNucleiTable.h
  • nucleiUtils.h is moved too the Utils folder, paths in tasks depending on this header file is updated accordingly
  • new utilities are added to nucleiUtils.h

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

O2 linter results: ❌ 95 errors, ⚠️ 0 warnings, 🔕 0 disabled

maciacco
maciacco previously approved these changes Oct 2, 2025
@alibuild
Copy link
Collaborator

alibuild commented Oct 3, 2025

Error while checking build/O2Physics/o2 for 1f13e26 at 2025-10-03 09:48:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:233:5: error: 'base' in namespace 'o2' does not name a type
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:289:73: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:299:78: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:304:82: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:309:87: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:314:87: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:319:88: error: 'o2::aod::evsel' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:551:12: error: 'ITSResponse' in namespace 'o2::aod' does not name a type
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:473:12: error: 'mResponseITS' was not declared in this scope
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:478:12: error: 'mResponseITS' was not declared in this scope
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:486:16: error: 'mResponseITS' was not declared in this scope
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:508:12: error: 'tpc' has not been declared
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:132:13: error: 'lut' is not a member of 'nuclei'
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/TableProducer/QC/nucleiQC.cxx:177:57: error: 'lut' is not a member of 'nuclei'
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:492:92: error: value computed is not used [-Werror=unused-value]
/sw/SOURCES/O2Physics/13212-slc9_x86-64/0/PWGLF/Utils/nucleiUtils.h:494:90: error: value computed is not used [-Werror=unused-value]
ninja: build stopped: subcommand failed.

Full log here.

Please consider the following formatting changes to AliceO2Group#13212
@maciacco maciacco enabled auto-merge (squash) October 3, 2025 08:19
maciacco
maciacco previously approved these changes Oct 3, 2025
auto-merge was automatically disabled October 3, 2025 08:48

Head branch was pushed to by a user without write access

@vkucera vkucera marked this pull request as draft October 3, 2025 16:34
@vkucera
Copy link
Collaborator

vkucera commented Oct 3, 2025

@GiorgioAlbertoLucia @maciacco Please do not leave PRs which do not pass required checks as "ready for review".

@GiorgioAlbertoLucia
Copy link
Contributor Author

Hi @vkucera, thank you for your comment. I think the change that made the PR formatting fail happened during the last alibuild merge and we were not expecting this behavior. We will be more cautious next time!

@GiorgioAlbertoLucia GiorgioAlbertoLucia marked this pull request as ready for review October 3, 2025 16:56
@maciacco maciacco enabled auto-merge (squash) October 5, 2025 13:01
@maciacco maciacco merged commit 70cef59 into AliceO2Group:master Oct 5, 2025
12 of 13 checks passed
@vkucera
Copy link
Collaborator

vkucera commented Oct 5, 2025

@GiorgioAlbertoLucia @maciacco The new PWGLF/Utils/nucleiUtils.h header has 4 using directives, reported by the O2 linter. Please do not leave these issues unfixed.

@GiorgioAlbertoLucia GiorgioAlbertoLucia deleted the nucleiqc branch October 5, 2025 14:17
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
…ate folder (AliceO2Group#13212)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
…ate folder (AliceO2Group#13212)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
…ate folder (AliceO2Group#13212)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
…ate folder (AliceO2Group#13212)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Comment on lines +31 to +34
using namespace o2;
using namespace o2::framework;
using namespace o2::framework::expressions;
using namespace o2::constants::physics;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about fixing these?

lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
…ate folder (AliceO2Group#13212)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants