Skip to content

Conversation

@ppoava
Copy link
Contributor

@ppoava ppoava commented Oct 1, 2025

Adding DCA information from dimuons to the muon QA task. This is necessary to study the MCH alignment in more detail, in particular regarding possible biases of mu plus and mu minus in the top and bottom halves of the first MCH chamber.

@ppoava ppoava requested review from a team, alibuild, ddobrigk, iarsene, jgrosseo and ktf as code owners October 1, 2025 16:45
@github-actions github-actions bot added the common label Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

O2 linter results: ❌ 161 errors, ⚠️ 0 warnings, 🔕 0 disabled

iarsene
iarsene previously approved these changes Oct 1, 2025
@iarsene iarsene enabled auto-merge (squash) October 1, 2025 17:02
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppoava Please fix the includes and be careful next time you rebase.
@iarsene Please do not approve PRs which revert previous fixes.

@vkucera vkucera marked this pull request as draft October 2, 2025 09:49
auto-merge was automatically disabled October 2, 2025 09:49

Pull request was converted to draft

@ppoava ppoava force-pushed the dimuons_DCA_study branch from 93b56a2 to 4dc2608 Compare October 3, 2025 09:33
@ppoava
Copy link
Contributor Author

ppoava commented Oct 3, 2025

@vkucera @iarsene
Thanks for letting me know, I didn't notice.

It's a bit weird what happened. I created a new branch and didn't rebase (because it was brand new and essentially no one else works on this code), then copied changes I had from my testing scripts.
It should be ok now, let me know if I missed something.

Thanks !

vkucera
vkucera previously approved these changes Oct 3, 2025
@vkucera
Copy link
Collaborator

vkucera commented Oct 3, 2025

@vkucera @iarsene Thanks for letting me know, I didn't notice.

It's a bit weird what happened. I created a new branch and didn't rebase (because it was brand new and essentially no one else works on this code), then copied changes I had from my testing scripts. It should be ok now, let me know if I missed something.

Thanks !

Thanks

@vkucera vkucera marked this pull request as ready for review October 3, 2025 09:53
Adding DCA information from dimuons to the muon QA task. This is necessary to study the MCH alignment in more detail, in particular regarding possible biases of mu plus and mu minus in the top and bottom halves of the first MCH chamber.
@ppoava ppoava force-pushed the dimuons_DCA_study branch from c3c73cb to b76e73e Compare October 6, 2025 14:05
@ddobrigk ddobrigk merged commit d3378cd into AliceO2Group:master Oct 7, 2025
12 of 13 checks passed
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
lmattei01 pushed a commit to lmattei01/O2Physics that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants